ivy icon indicating copy to clipboard operation
ivy copied to clipboard

bitwise_and Close #17637

Open samthakur587 opened this issue 1 year ago • 7 comments

bitwise_and Close #17637

samthakur587 avatar Jun 23 '23 14:06 samthakur587

hey @Ishticode i am facing error in formatting of the files can you please look into it. i am looking for some suggestion

thank you

samthakur587 avatar Jun 25 '23 05:06 samthakur587

hey @Ishticode can you please review the PR. because its very hard to solve the merge conflict again and again also the some else merged PR will overlap with my code and deficult to solve.

thank you

samthakur587 avatar Jun 26 '23 17:06 samthakur587

hey @hmahmood24 the changes in ivy_test folder are not made by me the changes came when i pull the branch in local there is not any commit made. i am trying but i am not finding any way to remove these changes. can you please help me to remove these changes.

thank you

samthakur587 avatar Jun 27 '23 07:06 samthakur587

hey @hmahmood24 the changes in ivy_test folder are not made by me the changes came when i pull the branch in local there is not any commit made. i am trying but i am not finding any way to remove these changes. can you please help me to remove these changes.

thank you

This is the commit where you've accidently pushed changes to the array_api_testing folder. You can revert this commit and then manually add your function and its test afterwards. Note that reverting this commit will remove any changes you made after it so copy and keep your function and the test somewhere safe and then add it back once you've reverted this commit.

hmahmood24 avatar Jun 27 '23 07:06 hmahmood24

hey @hmahmood24 i solved the problem of ivy_test_array . i found that the ivy_test_array folder has modified automatically due to running the pre-commit locally. i think the files are in ivy_test_array are not formated according to the pre-commit config. this the reason i am not able to run able to reformat my file with pre-commit.

so now PR is ready to merge but it has only the issue with formatting can you please check and let me know where is the problem in formatting.

thank you

samthakur587 avatar Jun 27 '23 08:06 samthakur587

hey @hmahmood24 all changes has done now the PR ready to merge

thank you

samthakur587 avatar Jun 27 '23 11:06 samthakur587

@hmahmood24 Thanks for taking this Mahmood.

Ishticode avatar Jun 27 '23 12:06 Ishticode

Looks good to merge now. Thanks for the PR! @samthakur587 🚀

hmahmood24 avatar Jun 28 '23 06:06 hmahmood24