ivy
ivy copied to clipboard
elu function implementation
Close #17456
#17558 this the issue for this pull
it's ready to review the pull
If you are working on an open task, please edit the PR description to link to the issue you've created.
For more information, please check ToDo List Issues Guide.
Thank you :hugs:
hey @hirwa-nshuti there is so much merge conflict happening in pull request so can i make a new pull request with a new branch
Hey @hirwa-nshuti
I have changed only the 6 file for my PR but to solve the merge conflict the 87 files had changed that are not related to my PR and not it not solving from my side can i make a new PR from a New branch to solve all the issue.
Thank you
finally all previous commit was reset @hirwa-nshuti now you can go ahead and review my PR
thanks
the issue number of subtask that i am working on is Extend Ivy Functional API #3856
the issue number of subtask that i am working on is Extend Ivy Functional API #3856
Would you refer to contributing guide and walk through the way to assign yourself a task https://unify.ai/docs/ivy/overview/contributing/open_tasks.html#open-tasks
sorry for the mistake i have added the PR number in place of issue number in PR description. Now i edited the PR description with issue number. you can check it.
thank you
hey @hirwa-nshuti previously i was implemented the elu activation function outside the ivy experimental API now i removed all the method from there and implemented with in ivy experimental api you can check now.
thank you
this test of the activation function silu and its not related to my PR. why it is coming i don't know can you please check why it is coming. what changes do i required to solve this.
thank you
hey @hirwa-nshuti completed all the changes . now its ready to merge
Hey @hirwa-nshuti i am trying to test the paddle frontend test in local i am getting the keyerror 'cpu' i don't where it is store and why this error is coming. can you please help me come out from this problem.
the command i run is : -
pytest -vv ivy_tests/test_ivy/test_frontends/test_paddle/test_nn/test_functional/test_paddle_activation.py::test_paddle_elu
thank you
hey @hirwa-nshuti i have run all the tests locally all are passing but one warring has encounter from numpy backed expm1 function that is show here .
do you has any suggestion to overcome from this. otherwise the PR was completed and ready to merge.
thank you
Finally all tests are passing locally. Now its Ready to merge .
thank you
Hey @hirwa-nshuti
That's awesome ! I really appreciate all the help and guidance you've provided throughout this process. It wouldn't have been possible without your valuable contributions.
Thanks a ton for your support! 😄