ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Paddle frontend: mse_loss #17400

Open Kamil2601 opened this issue 1 year ago • 2 comments

Close - [ ] #17400

Kamil2601 avatar Jun 21 '23 10:06 Kamil2601

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you :hugs:

ivy-leaves avatar Jun 21 '23 10:06 ivy-leaves

Hey @Kamil2601, thanks a lot for the PR. Some minor changes and we are good to go with the final tests

MuhammedAshraf2020 avatar Jun 22 '23 19:06 MuhammedAshraf2020

@MuhammedAshraf2020 fixed

Kamil2601 avatar Jun 25 '23 10:06 Kamil2601

Hi @Kamil2601, I wanted to let you know that the tests have encountered an issue. Specifically, there is an E AssertionError due to a discrepancy in shape between the returned value and the expected ground-truth value. The returned shape is (1,), whereas the ground-truth shape is empty.

It appears that the frontend function is not behaving in the same way as the original function, even though they have the same input shape and data type.

Screenshot from 2023-06-27 16-47-07

MuhammedAshraf2020 avatar Jun 27 '23 13:06 MuhammedAshraf2020

@MuhammedAshraf2020 the problem is with binary_cross_entropy_loss, not mse image

For me original paddle mse_loss returns tensor of shape (1,) image

Also documentation suggest the same image

Kamil2601 avatar Jun 27 '23 15:06 Kamil2601

It seems that there is a problem with different versions, we will have a look on that

MuhammedAshraf2020 avatar Jun 27 '23 16:06 MuhammedAshraf2020

LGTM

MuhammedAshraf2020 avatar Jun 27 '23 16:06 MuhammedAshraf2020