ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Published 20 hours ago • verified publisher icon Transpile-AI

Percentile Function

Open dhruvsaxena11 opened this issue 1 year ago • 3 comments

Hi,

Close #17469

I have added the percentile function in statistical functions of numpy frontend.

Please kindly check and review it.

Thank You

Dhruv Saxena

dhruvsaxena11 avatar Jun 20 '23 20:06 dhruvsaxena11

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you :hugs:

ivy-leaves avatar Jun 20 '23 20:06 ivy-leaves

@ivy-leaves

I have updated the description please kindly check.

Thank You

Dhruv Saxena

dhruvsaxena11 avatar Jun 21 '23 10:06 dhruvsaxena11

@ivy-leaves @zhumakhan

please kindly check my PR.

Thank You

dhruvsaxena11 avatar Jun 23 '23 10:06 dhruvsaxena11

Hi, thanks for you PR! Please also add test and decorators to the function like @to_ivy_arrays_and_back

zhumakhan avatar Jun 27 '23 10:06 zhumakhan

@zhumakhan

Hi,

I have updated the files and added the decorators to function and added the test. please kindly check and suggest.

Thank You

dhruvsaxena11 avatar Jun 27 '23 11:06 dhruvsaxena11

Could you please fix the implementation? Decorators in percentile.py file are not imported Thanks!

zhumakhan avatar Jul 03 '23 09:07 zhumakhan

@zhumakhan I updated the code please kindly check.

Thank You

dhruvsaxena11 avatar Jul 03 '23 12:07 dhruvsaxena11

@zhumakhan please kindly check and merge

dhruvsaxena11 avatar Jul 03 '23 14:07 dhruvsaxena11

Could you please follow how nanpercentile is implemented: https://github.com/unifyai/ivy/blob/master/ivy/functional/frontends/numpy/statistics/order_statistics.py#L51

zhumakhan avatar Jul 20 '23 16:07 zhumakhan

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Jul 30 '23 05:07 ivy-seed

Will working on it

dhruvsaxena11 avatar Jul 31 '23 17:07 dhruvsaxena11

@zhumakhan

I have updated the code.

please kindly see and merge.

Thank You

dhruvsaxena11 avatar Jul 31 '23 17:07 dhruvsaxena11

@zhumakhan

I have updated the code. Please kindly check and merge.

dhruvsaxena11 avatar Aug 19 '23 12:08 dhruvsaxena11

Hi, many tests are failing due to various reasons like shape related, unsupported dtypes and missing arguments to test function. Could you please thoroughly go through tests and fix them? Thanks!

zhumakhan avatar Sep 03 '23 19:09 zhumakhan

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Oct 10 '23 05:10 ivy-seed