ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Update the pdist() function for PyTorch frontend pdist #17097

Open shaimah opened this issue 1 year ago • 2 comments

Closes #17097

shaimah avatar Jun 20 '23 13:06 shaimah

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you :hugs:

ivy-leaves avatar Jun 20 '23 13:06 ivy-leaves

Hey @shaimah! Thanks for contributing! Just a minor detail, the default value of p should be 2 and x should be called input in the function arguments I believe, the frontend implementations should resemble their original counterparts as closely as possible, the test arguments should be updated with the new name accordingly as well.

Other than that the tests seem to be passing locally and in general the PR looks to be in good shape!

danielmunioz avatar Jun 21 '23 03:06 danielmunioz

@danielmunioz Looping you back in here. Not sure why the assignee was changed. Thanks!

theRealBird avatar Jun 29 '23 05:06 theRealBird

Hey @shaimah! I just checked your PR again, thanks for the changes! It seems to be working well and the tests are passing locally, the only thing left is to remove the asterisk for in the function definition (in the original function p is both a positional and keyboard argument), but I'll take care of that minuscule detail after merge!

Overall, LGTM! Merging Now

Thanks for contributing! 🚀

danielmunioz avatar Jul 03 '23 19:07 danielmunioz