ivy
ivy copied to clipboard
Update the pdist() function for PyTorch frontend pdist #17097
Closes #17097
If you are working on an open task, please edit the PR description to link to the issue you've created.
For more information, please check ToDo List Issues Guide.
Thank you :hugs:
Hey @shaimah! Thanks for contributing!
Just a minor detail, the default value of p
should be 2 and x should be called input
in the function arguments I believe, the frontend implementations should resemble their original counterparts as closely as possible, the test arguments should be updated with the new name accordingly as well.
Other than that the tests seem to be passing locally and in general the PR looks to be in good shape!
@danielmunioz Looping you back in here. Not sure why the assignee was changed. Thanks!
Hey @shaimah! I just checked your PR again, thanks for the changes! It seems to be working well and the tests are passing locally, the only thing left is to remove the asterisk for in the function definition (in the original function p is both a positional and keyboard argument), but I'll take care of that minuscule detail after merge!
Overall, LGTM! Merging Now
Thanks for contributing! 🚀