ivy icon indicating copy to clipboard operation
ivy copied to clipboard

add scan function

Open TimothyElems opened this issue 2 years ago • 6 comments

Add Control flow operators to Jax Frontend #1579

TimothyElems avatar Jun 20 '23 09:06 TimothyElems

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you :hugs:

ivy-leaves avatar Jun 20 '23 09:06 ivy-leaves

@Sam-Armstrong thank you! I'll get right on it!

TimothyElems avatar Jun 21 '23 01:06 TimothyElems

https://github.com/unifyai/ivy/issues/17449

TimothyElems avatar Jun 21 '23 01:06 TimothyElems

@Sam-Armstrong I used some previous tests from the same module and made the proper adjustments

Scan function's test #17450

TimothyElems avatar Jun 21 '23 01:06 TimothyElems

@TimothyElems please could you make the changes part of this pull request? You can do this by pushing to the same branch of your fork as before (TimothyElems:scan). Or alternatively we can close this PR and move to your new one 😅

Sam-Armstrong avatar Jun 21 '23 09:06 Sam-Armstrong

@Sam-Armstrong I've been stuck on a check. All others work but one. And it seems the bug was not caused by anything I interacted with. What could the solution be?

TimothyElems avatar Jun 21 '23 21:06 TimothyElems

@Sam-Armstrong The code works! My script works! The formats are clean! A new error persists? Thoughts?

TimothyElems avatar Jun 24 '23 03:06 TimothyElems

@Sam-Armstrong ALL SET!! Passed all checks!

TimothyElems avatar Jun 24 '23 22:06 TimothyElems

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Jul 05 '23 05:07 ivy-seed

@TimothyElems have you had chance to look at fixing the behaviour of 'unroll' and 'reverse' yet?

Sam-Armstrong avatar Jul 21 '23 21:07 Sam-Armstrong

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Jul 31 '23 05:07 ivy-seed

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Aug 15 '23 05:08 ivy-seed