ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Added laplace function to random sampling for numpy frontend and test function to ivy_tests

Open jasleen101010 opened this issue 1 year ago • 2 comments

Close #17353

jasleen101010 avatar Jun 19 '23 20:06 jasleen101010

ivy-gardener :white_check_mark: Ivy gardener has formatted your code. If changes are requested, don't forget to pull your fork.

bipinKrishnan avatar Jun 22 '23 10:06 bipinKrishnan

Hey @jasleen101010 , I think you forgot to lint your code. It's better if you install pre-commit which will automatically lint your changes before making the commit :slightly_smiling_face:

bipinKrishnan avatar Jun 22 '23 10:06 bipinKrishnan

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Jul 04 '23 05:07 ivy-seed

Also I just noticed that you are working directly on the master of your fork, as a best practice it is recommended to create a branch on your fork and make changes there rather than directly on the master :slightly_smiling_face:

bipinKrishnan avatar Jul 04 '23 12:07 bipinKrishnan

ivy-gardener :white_check_mark: Ivy gardener has formatted your code. If changes are requested, don't forget to pull your fork.

bipinKrishnan avatar Jul 04 '23 12:07 bipinKrishnan

Hey @jasleen101010 , it seems like something is wrong with the implementation of the test, it failing for all the backends due to some unexpected argument.

bipinKrishnan avatar Jul 06 '23 11:07 bipinKrishnan

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

ivy-seed avatar Jul 14 '23 05:07 ivy-seed