ivy icon indicating copy to clipboard operation
ivy copied to clipboard

added amax feature

Open AkshayVenkataraman opened this issue 1 year ago • 2 comments

Close #17138 Close #17220

AkshayVenkataraman avatar Jun 18 '23 11:06 AkshayVenkataraman

Hi @AkshayVenkataraman, thanks for the PR. There's a conflict in test_frontends.test_paddl.test_tensor.test_paddle_tensor.py. Additionally, The testing functions are not sufficient for the following args: Axis and num_dims need to be tested further. available_dtypes needs to test for more datatypes other than floats.

MuhammadSaeedBatikh avatar Jun 21 '23 00:06 MuhammadSaeedBatikh

Hello @MuhammadSaeedBatikh , I've made the changes, sorry it didn't catch my eye. Kindly let me know if it solves the problem!

AkshayVenkataraman avatar Jun 21 '23 03:06 AkshayVenkataraman

Thanks for your modifications. axis, num_dims, and available_dtypes tests are now more exhaustive; but there's still a merge conflict in the following two files: ivy/functional/frontends/paddle/tensor/math.py ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_paddle_math.py

MuhammadSaeedBatikh avatar Jun 21 '23 18:06 MuhammadSaeedBatikh

Thanks, @MuhammadSaeedBatikh, resolved them. You can merge now! :D

AkshayVenkataraman avatar Jun 21 '23 18:06 AkshayVenkataraman

lgtm.

MuhammadSaeedBatikh avatar Jun 21 '23 19:06 MuhammadSaeedBatikh

@AkshayVenkataraman @MuhammadSaeedBatikh There is an issue in this pull request (PR) in the file ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_paddle_math.py. The problem occurs when anyone tries to run a test on any function, and it throws the following error: TypeError: accept.<locals>.dtype_and_values() got an unexpected keyword argument 'min_axis'.

MuhammadNizamani avatar Jun 22 '23 08:06 MuhammadNizamani

Hi @MuhammadNizamani, thanks for pointing out this issue. Indeed, there's a problem with the test function that wasn't showing up. Unfortunately, there's some conflict issues, so I'm unable to revert directly. @AkshayVenkataraman will create a fix PR now. To @AkshayVenkataraman, please change the test function as such:

@handle_frontend_test(
    fn_tree="paddle.amax",
    dtype_and_x=helpers.dtype_and_values(
        available_dtypes=helpers.get_dtypes("numeric"),
    ),
)

Or delete mentions of paddle amax for now and start from a clean repo with no merge conflicts. Thanks

MuhammadSaeedBatikh avatar Jun 22 '23 10:06 MuhammadSaeedBatikh