ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Add numpy.fft.fftn frontend

Open RohitSgh opened this issue 2 years ago • 2 comments

Close #17028

RohitSgh avatar Jun 17 '23 20:06 RohitSgh

Hi @sherry30. Can you please help me why checks are failing?

RohitSgh avatar Jun 20 '23 15:06 RohitSgh

Please check again @sherry30

Can more details be provided on what exactly intelligent-tests-pr / run_tests (1) (pull_request) and intelligent-tests-pr / run_tests (24) (pull_request) are?

RohitSgh avatar Jun 22 '23 09:06 RohitSgh

Also, my issue is not being added to list https://github.com/unifyai/ivy/issues/1532. Have tried both way #17028 and - [ ] #17028

RohitSgh avatar Jun 25 '23 02:06 RohitSgh

Also, my issue is not being added to list #1532. Have tried both way #17028 and - [ ] #17028

I've added your issue manually in the list

sherry30 avatar Jun 27 '23 01:06 sherry30

Frontend Task Checklist

IMPORTANT NOTICE 🚨:

The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process.

LEGEND 🗺:

  • ❌ : Check item is not completed.
  • ✅ : Check item is ready for review.
  • 🆘 : Stuck/Doubting implementation (PR author should add comments explaining why).
  • ⏩ : Check is not applicable to function (skip).
  • 🆗 : Check item is implemented and does not require any edits.

CHECKS 📑:

    • [ ] ❌: The function/method definition is not missing any of the original arguments.
    • [ ] ❌: In case the function/method to be implemented is an alias of an existing function/method:
        • [ ] ❌: It is being declared as such by setting fun1 = fun2, rather than being re-implemented from scratch.
        • [ ] ❌: The alias is added to the existing function/method's test in the aliases parameter of handle_frontend_test/handle_frontend_method.
    • [ ] ❌: The naming of the function/method and its arguments exactly matches the original.
    • [ ] ❌: No defined argument is being ignored in the function/method's implementation.
    • [ ] ❌: In special cases where an argument's implementation should be pending due to an incomplete superset of an ivy function:
        • [ ] ❌: A descriptive comment has been left under the Implement superset behavior ToDo list in https://github.com/unifyai/ivy/issues/6406.
        • [ ] ❌: A ToDo comment has been added prompting to pass the frontend argument to the ivy function whose behavior is to be extended.
    • [ ] ❌: In case a frontend function is being added:
        • [ ] ❌: It is a composition of ivy functions.
        • [ ] ❌: In case the needed composition is long (using numerous ivy functions), a Missing Function Suggestion issue has been opened to suggest a new ivy function should be added to shorten the frontend implementation.
        • [ ] ❌: @to_ivy_arrays_and_back has been added to the function.
    • [ ] ❌: In case a frontend method is being added:
        • [ ] ❌: It is composed of existing frontend functions or methods.
        • [ ] ❌: If a required frontend function has not yet been added, the method may be implemented as a composition of ivy functions, making sure that:
          • [ ] ❌: @to_ivy_arrays_and_back has been added to the method.
          • [ ] ❌: A ToDo comment has been made prompting to remove the decorator and update the implementation as soon as the missing function has been added.
    • [ ] ❌: The function/method's test has been added (except in the alias case mentioned in <2>):
        • [ ] ❌: All supported arguments are being generated in handle_frontend_test/handle_frontend_method and passed to test_frontend_function/test_frontend_method.
        • [ ] ❌: The argument generation covers all possible supported values. Array sizes, dimensions, and axes adhere to the full supported set of the original function/method.
        • [ ] ❌: The available_dtypes parameter passed to the helper generating the function/method's input array is set to helpers.get_dtypes("valid"). If there are unsupported dtypes that cause the test to fail, they should be handled by adding @with_supported_dtypes/@with_unsupported_dtype to the function/method.
    • [ ] ❌: The PR is not introducing any test failures.
        • [ ] ❌: The lint checks are passing.
        • [ ] ❌: The implemented test is passing for all backends.
    • [ ] ❌: The PR closes a Sub Task issue linked to one of the open frontend ToDo lists.
    • [ ] ❌: The function/method and its test have been added to the correct .py files corresponding to the addressed ToDo list.
    • [ ] ❌: The PR only contains changes relevant to the addressed subtask.

RohitSgh avatar Jun 27 '23 16:06 RohitSgh

Please review @sherry30. Only 1 failing check now intelligent-tests-pr / run_tests (24) (pull_request)

RohitSgh avatar Jun 27 '23 16:06 RohitSgh

Please review @sherry30. Only 1 failing check now intelligent-tests-pr / run_tests (24) (pull_request)

Now, also 1 failing, but is has changed to intelligent-tests-pr / run_tests (1) (pull_request), @sherry30

RohitSgh avatar Jun 28 '23 06:06 RohitSgh

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Jul 11 '23 05:07 ivy-seed

Working @ivy-seed

RohitSgh avatar Jul 11 '23 05:07 RohitSgh