ivy
ivy copied to clipboard
Published
20 hours ago •
Transpile-AI
Transpile-AI
Logit added
If you are working on an open task, please edit the PR description to link to the issue you've created.
For more information, please check ToDo List Issues Guide.
Thank you :hugs:
Hey @shivam-151197 , thanks a lot for the PR. I have to mention some points though:
- There are some tests that your PR is failing. Kindly look into those here and fix them.
- I'm guessing you haven't installed pre-commit since it automatically runs all these checks whenever you commit your code and push it. I suggest you set up pre-commit in your local environment and run these linting and formatting checks because otherwise the CI tests will fail every time you submit a PR that has linting and formatting issues.
- Besides you have been advised earlier to link the issue to the PR description here and have been shared a guide. Please ensure that your PR follows the guide.
- I'm guessing you didn't run the tests locally because pytest would have thrown an error. Kindly always make sure that you run all your tests locally and ensure that they pass for ALL backends because otherwise the CI tests will fail when you submit a PR. When you've done all these changes and verified that the tests are passing, feel free to ask for a re-review from me 🙂
Good luck!
@satakshigarg I have created a new PR for the issue #17362. Kindly Review #17787. I have considered all your suggestions.