ivy icon indicating copy to clipboard operation
ivy copied to clipboard

`quantize_linear` compositional func in Experimental API

Open mobley-trent opened this issue 2 years ago • 5 comments

Closes #16427

mobley-trent avatar Jun 08 '23 15:06 mobley-trent

Temporarily removed support for the axis argument. Having issues with the tests

mobley-trent avatar Jun 10 '23 10:06 mobley-trent

Commenting for context, PR is related to this task -: https://trello.com/c/bM30qW9Z

Aarsh2001 avatar Jun 15 '23 16:06 Aarsh2001

Hey @mobley-trent, kindly let us know in the comments whenever this PR is ready for review, thanks 🙂

Aarsh2001 avatar Jun 23 '23 05:06 Aarsh2001

@Aarsh2001 I don't know why JAX is returning inconsistent results with the rest of the backends

mobley-trent avatar Jun 23 '23 16:06 mobley-trent

Just pushed a fix for the inconsistent test results, but I still don't know how we should proceed to support the axis argument

mobley-trent avatar Jun 23 '23 17:06 mobley-trent

The code is consistent to the original QuantizeLinear function but I'm still running into problems setting up the test

mobley-trent avatar Jul 03 '23 21:07 mobley-trent

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ivy-seed avatar Jul 11 '23 05:07 ivy-seed

Hi @mobley-trent , are you still working on this function?

MahmoudAshraf97 avatar Aug 15 '23 22:08 MahmoudAshraf97

@MahmoudAshraf97 I put it on hold since there doesn't seem to be active development on the issue list for these functions, as I have not seen any other PRs being merged. But my PR is still active.

mobley-trent avatar Aug 16 '23 12:08 mobley-trent

My tests are not running for some reason. Even the function in the Ivy API doesn't work when I try running it on a sample script; I'm getting this error:

ImportError: cannot import name '_wrap_function' from partially initialized module 'ivy.func_wrapper' (most likely due to a circular import) (/workspaces/ivy/ivy/func_wrapper.py)

mobley-trent avatar Aug 16 '23 13:08 mobley-trent

hi @mobley-trent , I'm going to close this PR to clear some PR backlog, feel free to open a new one once this function is ready to merge

MahmoudAshraf97 avatar Aug 20 '23 22:08 MahmoudAshraf97