Roy Moore

Results 75 comments of Roy Moore

4th part is up: https://github.com/testcontainers/testcontainers-python/pull/655

Done: - https://github.com/testcontainers/testcontainers-python/pull/585 - https://github.com/testcontainers/testcontainers-python/pull/595 - https://github.com/testcontainers/testcontainers-python/pull/612 - https://github.com/testcontainers/testcontainers-python/pull/655

@alexanderankin sorry to say but the latest changes broke the new planned test. Now the config is loaded even before the `DockerRegistryContainer` invocation/build so the test cannot build DOCKER_AUTH_CONFIG using...

https://github.com/testcontainers/testcontainers-python/pull/582

I think we can assume this is a different use case (based on https://docs.gitlab.com/ee/ci/docker/using_docker_images.html#use-credential-helpers) credential-helpers also uses `DOCKER_AUTH_CONFIG` but it has a different scheme: ``` { "credHelpers": { ".dkr.ecr..amazonaws.com": "ecr-login"...

Another alternative is to follow `testcontainers-java` https://github.com/testcontainers/testcontainers-java/blob/994b385761dde7d832ab7b6c10bc62747fe4b340/core/src/main/java/org/testcontainers/utility/RegistryAuthLocator.java#L141 and implement all the use cases: - helper - credsHelper - base64 encoded auth (This is the one we currently have) This is...

@alexanderankin I also have an idea on how we can be more visible regarding this and on the same time avoid the problem @alvaromerinog is facing. I'll try and create...

I need to do some investigation regarding the actual process we will need to invoke. Regarding separate process, I always feel a bit uncomfortable just calling other programs in python...

1. I Think we need some extra permissions on the repo to be able to use [coveralls](https://coveralls.io/) or [codecov](https://about.codecov.io/) 2. On a more positive note, I think I can get...

Maybe I was very wrong? https://app.codecov.io/gh/testcontainers/testcontainers-python Its already configured (or was configured?)