jxlatte icon indicating copy to clipboard operation
jxlatte copied to clipboard

Add Maven build support

Open meiMingle opened this issue 2 years ago • 11 comments

meiMingle avatar Jan 03 '24 03:01 meiMingle

I'm not sure where you're getting com.github.traneptora from - also you need to squash the commits.

Traneptora avatar Jan 03 '24 15:01 Traneptora

I'm not sure where you're getting com.github.traneptora from

I just defined it based on your github account name, do you have a suggested GroupId?

also you need to squash the commits.

Yes, I will do this later

meiMingle avatar Jan 04 '24 01:01 meiMingle

I just defined it based on your github account name, do you have a suggested GroupId?

As far as I understand it should be equal to the package name directly above the project. The project's base package is com.traneptora.jxlatte so as far as I understand, com.traneptora should be used. Although I may be mistaken.

Traneptora avatar Jan 04 '24 22:01 Traneptora

Update: I forgot to rename the package when I changed my username, but it should be renamed now.

Traneptora avatar Jan 04 '24 22:01 Traneptora

Now, I have finished modifying

meiMingle avatar Jan 05 '24 01:01 meiMingle

pom.xml is missing a newline at the end of the file. Otherwise, I can test this today.

Traneptora avatar Jan 13 '24 15:01 Traneptora

pom.xml is missing a newline at the end of the file. Otherwise, I can test this today.

Yes, I just fixed it

meiMingle avatar Jan 15 '24 01:01 meiMingle

Make sure you squash the commits, then I can review.

Traneptora avatar Jan 25 '24 16:01 Traneptora

Make sure you squash the commits, then I can review.

@Traneptora In GitLab you can squash it when you accept the merge request. I would assume the same is possible on GitHub. Is it not?

BuZZ-dEE avatar Oct 29 '24 11:10 BuZZ-dEE

I only use Rebase And Merge because Squash and Merge makes silly commit messages. As such, I request a squash before I will review it.

Traneptora avatar Oct 31 '24 09:10 Traneptora

Commits has been squashed.

meiMingle avatar Nov 12 '24 09:11 meiMingle