Leo Izen
Leo Izen
The compressed size of a `brob` box is not useful if libjxl is set to silently decompress them (which iirc is the default). It makes more sense to get the...
Something somewhere is not tonemapping properly. `cjpegli` is decoding to pixels with an ICC profile: `ColorSync color profile 4.4, type jxl, RGB/Lab-mntr device by jxl, 4344 bytes, 1-12-2019, 0xde06c4e002fc07e4 MD5...
Notably, the JXL file has an attached ICC profile and is XYB encoded. djxl is outputting a PNG in Linear Light rather than in sRGB.
> There are three things that would fix this, and I think we need to do all of them: > 2. Make djxl default to writing a 16-bit png if...
> It makes sense that we currently don’t recognize it as we make no attempt to recognize pure gamma curves. Why not? It seems very doable if there's a `curv`...
Do note that this may be an error with the actual PNG viewer. `djxl input.jxl output.png` for the Jungle image results in a PNG file that has `cICP` tags setting...
Likewise, the image on the right looks exactly like what you'd get if you interpret the BT2100/PQ png that was output as though it were sRGB. You can test this...
> Even then, we used to also generate a fallback ICC chunk. That we don’t anymore is a regression, apparently introduced by #2635. I’ll have a closer look next week....
> Do we have any example of a program that can properly view PNG with cICP? Chromium and FFmpeg both support cICP chunks.
I can still reproduce this, albeit for an entirely different reason: ``` $ benchmark_xl --input=white.png --save_decompressed benchmark_xl v0.10.0 5ab436a5 [AVX2] 8 total threads, 1 tasks, 0 threads, 8 inner threads...