Quentin VERMANDE
Quentin VERMANDE
Hi ! It is probably a bit late to appear, but I have just done the merging (after unsurprisingly not being able to make DME work on Mac). It still...
> You seem to have created the PR from your master branch. Indeed, is that bad practice ?
> > Indeed, is that bad practice ? > > Yes. :-) Oh, sorry. I do not see a way to change the branch now, I will pay attention in...
I have just tried to rebase. The HB.instance line 2040 does not compile and I could not fix it (everything else works fine).
> > I have just tried to rebase. The HB.instance line 2040 does not compile and I could not fix it (everything else works fine). > > You mean `fun_orderedConvType`?...
Your second proofreading does not appear in the list of commits. Besides, the definition of linear_affine was broken due to HB, I have just fixed it.
Ah ok, then everything is all right.
I would not go so far as "ought to", the fix is quite trivial, but if you would prefer a different PR, I can do it.
Can I also rebase and clean up now?
Reopened at https://github.com/math-comp/analysis/pull/1198