?q= missing since 3.8.0

[WouterGritter]

I relied on the q parameter being available in index.php for my project, however it seems to have been removed since 3.8.0 by this commit.

Any particular reason for the removal?

[TrafeX]

Hi @WouterGritter,

I'm sorry that it broke your project. I removed it, because it's not a good practice to add the URI as separate query param. This would give unexpected results when the q query param is added to the URL, because that would override it.

I checked out your project, but I couldn't find a reference to the q parameter. Where are you using that? I might be able to suggest a different way of handling it.

[WouterGritter]

That makes sense, thanks. I refactored this logic by using PHP's $_SERVER['DOCUMENT_URI'] along with a custom default.conf nginx config file to override the docker image's default one, so it's all good.

I'm not sure how widely used the docker image is -- might it be a good idea to add a README section for breaking changes like this one? Possibly suggesting a quick fix, e.g. using docker image tag 3.7.0.

Dankjewel!

[TrafeX]

In hindsight, this should've been a major version since it breaks existing behavior. Thank you for pointing that out!