traewelling icon indicating copy to clipboard operation
traewelling copied to clipboard

feat: remove unnecessary cookie alert

Open pReya opened this issue 2 years ago • 6 comments

  • remove the cookie notice/alert since it's legally not required

According to GDPR, a cookie banner is only necessary for cookies which are NOT technically required for the website to work properly. Since the only cookie that Traewelling is setting is a default Laravel session cookie, it is absolutely "technically required". There is no need to ask for consent or even show a cookie notice at all for this cookie. Mentioning it in the "Privacy" page is already enough.

My partner is a privacy lawyer, so we talk about this stuff a lot, and Traewelling is a pretty clear case ;)

pReya avatar Oct 31 '23 05:10 pReya

I've thought about it before, but discarded the idea when I took another closer look at Träwelling. I haven't really looked into the legal perspective of data protection at Träwelling, @HerrLevin has taken care of it so far.

But when I look at the Träwelling landing page as a non-logged in user, I receive two cookies:

  1. XSRF-TOKEN -> technically necessary
  2. trwl_session -> I'm unsure here.

The cookie stores a unique ID of the visitor - and then also in the database. This seems to come from a standard Laravel (UI?) implementation, but I don't know why this is necessary. I would like to clarify that beforehand.

image

MrKrisKrisu avatar Nov 04 '23 13:11 MrKrisKrisu

The session cookie is there to identify the user, which is the main (one might even say the only) part of Träwellings functionality. It is (without a doubt) technically necessary. You will find a lot of consistent information on this topic if you google "session cookie gdpr".

The relevant section of the law in this regard is § 25 (2) Nr. 2 TTDSG (https://dsgvo-gesetz.de/ttdsg/25-ttdsg/)

pReya avatar Nov 05 '23 07:11 pReya

There's no reason to identify a user if they are not logged in

NyCodeGHG avatar Nov 05 '23 11:11 NyCodeGHG

There's no reason to identify a user if they are not logged in

I agree, the session cookie is currently already being set, when the home page is loaded – this is unnecessary. But it's also a different ticket/issue in my opinion, and not related to the cookie alert.

EDIT: I've created a new issue for this behavior: https://github.com/Traewelling/traewelling/issues/2101

pReya avatar Nov 05 '23 19:11 pReya

I've added the label needs discussion because I think we need to first discuss about #2101 before rolling this out.

I totally agree that we don't want any cookies which need the agreement of the user - and I understand that the login cookie is technically required.

But as already mentioned, laravel is saving a default session cookie for every user - including the ip and user agent. In my opinion this should be fixed first.

MrKrisKrisu avatar Nov 21 '23 21:11 MrKrisKrisu

I've added the label needs discussion because I think we need to first discuss about #2101 before rolling this out.

I totally agree that we don't want any cookies which need the agreement of the user - and I understand that the login cookie is technically required.

But as already mentioned, laravel is saving a default session cookie for every user - including the ip and user agent. In my opinion this should be fixed first.

I understand your position. But legally, these are totally separate topics. The cookie notice is not required – even if #2101 is not implemented / implemented at a later point in time.

pReya avatar Nov 22 '23 09:11 pReya

Since there was no further interaction or other opinions here, I would close the PR for now. If issue #2101 is resolved, I would welcome the removal of the cookie banner!

MrKrisKrisu avatar Apr 27 '24 12:04 MrKrisKrisu

Since there was no further interaction or other opinions here, I would close the PR for now. If issue #2101 is resolved, I would welcome the removal of the cookie banner!

Just to repeat myself: These are unrelated topics. This can be merged, even without the other issue.

pReya avatar Apr 28 '24 08:04 pReya