react-native-highcharts icon indicating copy to clipboard operation
react-native-highcharts copied to clipboard

Updated WebView library (the one being used is gonna be removed) and iOS error

Open BernaLang opened this issue 5 years ago • 9 comments

According to the React Native Docs the <WebView/> is going to be removed from React Native core and we should instead use react-native-community/react-native-webview.

BernaLang avatar Apr 15 '19 10:04 BernaLang

note that this has a problem with expo

zeritte avatar Jun 21 '19 08:06 zeritte

I'm having issues adding this fork as I think the source package.json has an invalid semver version...

$ yarn add git+https://github.com/BernaLang/react-native-highcharts.git#86ce7bf
yarn add v1.16.0
[1/4] 🔍  Resolving packages...
error Can't add "react-native-highcharts": invalid package version "1.1".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

njt1982 avatar Jul 23 '19 07:07 njt1982

I'm having issues adding this fork as I think the source package.json has an invalid semver version...

$ yarn add git+https://github.com/BernaLang/react-native-highcharts.git#86ce7bf
yarn add v1.16.0
[1/4] 🔍  Resolving packages...
error Can't add "react-native-highcharts": invalid package version "1.1".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

I changed the version, it should work now 😄

BernaLang avatar Jul 23 '19 09:07 BernaLang

note that this has a problem with expo

I don't really work with expo, could you tell me what the problem is?

BernaLang avatar Jul 23 '19 09:07 BernaLang

Added a new commit to fix a iOS error by whitelisting the file directory on the webview.

BernaLang avatar Jul 23 '19 09:07 BernaLang

only error im getting in my testflight build is related to the deprecated webview from this package, any chance this will be merged soon?

rgordon95 avatar Aug 31 '19 22:08 rgordon95

can you please update ASAP . since our app usage a lot of highcharts and in the latest release of react-native does not support webview from react-native . Please replace it with webview from react-native-webview

intruder09 avatar Sep 02 '19 11:09 intruder09

Do you know when this pull request will be merge ? We need it to use it with react-native 0.59.

flapotre avatar Sep 03 '19 14:09 flapotre

Please accept the pull request so we can update our application.

redsharpie avatar Sep 24 '19 15:09 redsharpie