TradeShop
TradeShop copied to clipboard
2.6.2 - Fix JsonShopConfiguration saves
Pull Request Etiquette
There are several guidelines you should follow in order for your Pull Request to be merged.
Replace [ ]
with [x]
to cross the checkbox.
- [x] I have checked the PRs for upcoming features/bug fixes.
- [x] I have read the contributing guidelines.
It is sometimes better to include more related changes in a single commit. If you find yourself having an overwhelming amount of commits, you can rebase your branch.
Changes
Fix for bug reported on discord about shop deletion not being saved/reflected in save files. Also introduces a thread (task) pool system for better performance. The previous async saving implementation relying on HashMaps as semaphores/locks was only a band-aid fix.
I have done some basic testing with 1-2 threads, more stress-testing (more queued save jobs, more threads) would be helpful.