sam-cli-action
sam-cli-action copied to clipboard
aws-sam-cli being installed multiple times
Is your feature request related to a problem? Please describe.
entrypoint.sh
contains installAwsSam
which installs aws-sam-cli every time.
Describe the solution you'd like
- If possible, use a different docker image like https://registry.hub.docker.com/r/vukomir/aws-sam-cli that comes with nodejs and aws-sam-cli.
- Add a check on
entrypoint.sh
to check forsam --version
and install sam cli based on that output.
Describe alternatives you've considered
None.
Additional context
N/A
@aprilmintacpineda if you can please put up a PR. Using the docker image you linked will save a lot of time when the action runs.
Sure thing!
While I'm not against this approach (anything that speeds up builds its great!!), the version of SAM in this docker image is very old. Just something to be aware of @aprilmintacpineda @cody-hoffman
Actually I tried out not using this, turns out sam-cli and it's dependencies are installed by default on github actions, I was able to build and deploy without this tool
@aprilmintacpineda can you share an example of how that works?
Under the Virtual Environments Docs there is a list of preinstalled software. AWS SAM is listed. https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#cli-tools