pluginval icon indicating copy to clipboard operation
pluginval copied to clipboard

Validation in GUI should be "in process" by default?

Open sudara opened this issue 1 year ago • 2 comments

Scanning is nice out of process, but I think it's a common papercut to have to manually check "in process" to get good stack traces.

I personally never run the GUI out of process. But I have been caught out by it not being the default. Thoughts?

sudara avatar Dec 04 '24 17:12 sudara

This might be a throwback of how pluginval originally ran but does "in-process" still mean in the same process as the gui?

If so, that's probably not what you want right? As it will kill the app and only give you a stack trace if you happen to be attached to a debugger?

drowaudio avatar Dec 05 '24 14:12 drowaudio

Do you ever run pluginval locally without the debugger attached?

95% of the time I'm doing this:

  • CI has a validation failure or crash
  • I build and run pluginval locally, with debugger attached to diagnose

As described here:

https://github.com/Tracktion/pluginval/blob/develop/docs/Debugging%20a%20failed%20validation.md#quick-debugging

But you are right, if someone is checking out pluginval for the first time, downloads the release zip and in-process is default, their plugin crashing would crash pluginval.

In-process could be the default for Debug mode. The assumption being if you are building locally, you are debugging... Hm...

sudara avatar Dec 05 '24 15:12 sudara