tracker-control-android icon indicating copy to clipboard operation
tracker-control-android copied to clipboard

Published 20 hours ago • verified publisher icon TrackerControl

Accessibility issues

Open PrivacyDragon opened this issue 3 years ago • 7 comments

Issue: The app list shows an app icon followed by it's name and sometimes some information thing. The app icon is a button. If you click on it, you disable internet access for that application. The problem is that the button is not labeled. A blind user can not hear what it is and what it does.

Fix: Add labels to the buttons. For example "Disable internet access for ..."

I might want to try to fix this myself if possible. If it is easy enough for me. It seems to me pretty easy, though sometimes I think something is easier than it actually is.

(I also posted this issue in my accessibility-hub repository: https://github.com/PrivacyDragon/FOSS-accessibility-hub/issues/7)

PrivacyDragon avatar Jul 20 '21 20:07 PrivacyDragon

I agree that this is really poor practice. Thanks for raising this!

kasnder avatar Jul 21 '21 11:07 kasnder

I've added it to the top of my todos.

kasnder avatar Jul 21 '21 11:07 kasnder

What needs to be done is adding a label to this image: https://github.com/OxfordHCC/tracker-control-android/blob/3abc89d53b4d99596b0f62ed04ec855f42b3edda/app/src/main/res/layout/rule.xml#L12

kasnder avatar Jul 21 '21 11:07 kasnder

Maybe, you could make a pull request, @PrivacyDragon ?

kasnder avatar Jul 21 '21 11:07 kasnder

I will try. Thanks for pointing out where the image is located in the code.

PrivacyDragon avatar Jul 21 '21 20:07 PrivacyDragon

I will try. Thanks for pointing out where the image is located in the code.

Great, thanks! Give it a try, otherwise I'm happy to look into it.

kasnder avatar Jul 22 '21 06:07 kasnder

@PrivacyDragon Thanks for the PR. I've merged this. I'll leave this open for further investigation.

kasnder avatar Jul 22 '21 17:07 kasnder