nativelink icon indicating copy to clipboard operation
nativelink copied to clipboard

Achieve metrics coverage on stores

Open blakehatch opened this issue 1 year ago • 3 comments

The stores that are missing metrics are:

  • [x] Completeness Checking Store
  • [ ] Dedup Store
  • [ ] Grpc Store
  • [ ] Noop Store
  • [ ] Ref Store
  • [ ] S3 Store
  • [x] Size Partitioning store

blakehatch avatar Feb 01 '24 15:02 blakehatch

Not saying I'm against implementing it in the current infra, but I want to mention that this could be a waste of time to implement in our current setup. If we do this now we'll need to port all those metrics over to the otel-subscriber later. If we migrate to otel-subscriber first and change the log, error, info etc messages to the more idiomatic instrumentation syntax we get all these metrics for free.

aaronmondal avatar Feb 01 '24 16:02 aaronmondal

Oh wow I actually didn't know otel gives us metrics through logging that's really nice. Will leave this here for now as a reference for which stores have metrics currently for cloud and which don't then we can close this issue along with the otel migration.

blakehatch avatar Feb 01 '24 17:02 blakehatch

Is this still an issue? Cc @blakehatch

MarcusSorealheis avatar Jul 25 '24 05:07 MarcusSorealheis