tracardi-gui icon indicating copy to clipboard operation
tracardi-gui copied to clipboard

Published 20 hours ago • verified publisher icon Tracardi

Add i18n

Open victorzhangw opened this issue 2 years ago • 5 comments

Is there an opportunity to add i18n ?

victorzhangw avatar Sep 24 '22 03:09 victorzhangw

@victorzhangw we were considering this but currently we are developing so fast that it would only slow the development. And it is pretty complex right now as the plugin configuration is served from the server side.

atompie avatar Sep 25 '22 20:09 atompie

I create a broken branch for my company, the branch has implemented i18n by react-intl. If necessary I can submit a PR.

Nov-10-2022 18-33-26

Nov-10-2022 18-31-38

ryomahan avatar Nov 10 '22 10:11 ryomahan

@ryomahan I would love to see it.We have made an approach to i18n the system but it requires a lot of work also on the backend side. I postponed it to the 1.0 version as it is a huge amount of work an to do this probably some i8n system would be needed to manage all the languages.

atompie avatar Nov 11 '22 08:11 atompie

My solution is relatively simple and may not be the best one. I will integrate it on current branch and submit a PR in near future, and we can discuss it on the basis of the PR to optimize it to meet the project requirements.

ryomahan avatar Nov 11 '22 09:11 ryomahan

@atompie I push a PR #250 for this.

ryomahan avatar Nov 16 '22 10:11 ryomahan