tracardi-gui icon indicating copy to clipboard operation
tracardi-gui copied to clipboard

Add props to components

Open atompie opened this issue 3 years ago • 12 comments

We have been developing very fast. A lot of components does not have propTypes set. The code needs some factoring and the props would be very useful.

Just pick one component and add props definition.

atompie avatar Jul 26 '21 19:07 atompie

Happy to take a run at these. Just to confirm you want PropTypes added?

danjohnson77 avatar Jul 27 '21 03:07 danjohnson77

@danjohnson77 Yes I do :)

atompie avatar Aug 06 '21 19:08 atompie

Gotcha, just wrapping a build but can get into it in the next couple days, thanks!

danjohnson77 avatar Aug 10 '21 19:08 danjohnson77

@danjohnson77 Sure thing - no problem :)

atompie avatar Aug 11 '21 13:08 atompie

@atompie Hi just checking in, did anything need correcting on the PR?

danjohnson77 avatar Sep 13 '21 19:09 danjohnson77

@danjohnson77 The props are fine, but there are a lot of other changes regarding code formatting. Probably the changes were made by your IDE. I you could just commit the changes in props that could be a lot easier for me to review the PR.

atompie avatar Sep 13 '21 20:09 atompie

@atompie Understood, yeah looks like prettier got ahold of it. Will redo and submit new PR thanks

danjohnson77 avatar Sep 13 '21 20:09 danjohnson77

@danjohnson77 thanks. :)

atompie avatar Sep 13 '21 20:09 atompie

@atompie I'll also continue on this issue, do you have a preference on how many components are in a PR? As in, should I do just a few at a time and submit? Or do all of them in one big PR?

danjohnson77 avatar Sep 15 '21 18:09 danjohnson77

@danjohnson77 I do not have any preferences. You may do it as it suits you :)

atompie avatar Sep 15 '21 18:09 atompie

@danjohnson77 as to new issues, we have some places in UI that need new components. I will describe it and get back to you. I can also give you a hand if you need a help with on boarding to the project.

atompie avatar Sep 15 '21 18:09 atompie

@atompie Sounds great!

danjohnson77 avatar Sep 15 '21 18:09 danjohnson77