Entity_Texture_Features icon indicating copy to clipboard operation
Entity_Texture_Features copied to clipboard

[BUG] Huge lag spikes on player join on specific server

Open BlueGradientHorizon opened this issue 1 year ago • 3 comments

Describe the issue

  • What happened? I'm experiencing huge lag spikes when players join server's lobby.
  • What were you doing when it happened? Playing on server revage.net. Open FPS graph (F3+2) and observe it while staying in the lobby while players are joining.
  • Does this issue also occur with OptiFine? [yes/no] I don't use OF.

Screenshots

2024-12-12_16 57 05

Crash log

No crashes.

My setup:

  • Minecraft version: 1.21.4
  • ModLoader: Fabric
  • ETF Version: 6.2.9
  • Does the issue persist with only ETF installed?: Yes, while testing I was only using ETF and ViaFabricPlus (the server is outdated)
  • Have you checked the FAQ in the Readme, or Discord, to see if it is a known issue?: Yes, I didn't find any mentions of this issue anywhere.
  • Resource packs applied: None

I also was trying to reproduce this issue on a local 1.21.4 Fabric server but it's not reproducible in that case. Also I've noticed that this lag only happens when player's spawn point in your FOV, so it doesn't happen if you watch in opposite direction.

BlueGradientHorizon avatar Dec 12 '24 14:12 BlueGradientHorizon

do you know how to use the spark mod to get a client profile? one of those would be very handy

Traben-0 avatar Dec 12 '24 14:12 Traben-0

Looks like I found the source of problem. Spark profile. https://github.com/Traben-0/Entity_Texture_Features/blob/17d4725a2eed8ca05e12a0c350a80b0c5f46028a/common/src/main/java/traben/entity_texture_features/features/player/ETFPlayerTexture.java#L107 Lags are coming from texture downloader (is it done on render thread?).

BlueGradientHorizon avatar Dec 12 '24 15:12 BlueGradientHorizon

I'll look into it

Traben-0 avatar Dec 12 '24 15:12 Traben-0