sputnik icon indicating copy to clipboard operation
sputnik copied to clipboard
verified publisher icon TouK

Bump checkstyle to 10.21.1 and CodeNarc to 3.5.0

Open Jimver opened this issue 11 months ago • 2 comments

  • Bump the checkstyle dependency from 8.1 to the latest version 10.21.1
  • This is needed in particular for Java 21 support, see releasenotes: https://checkstyle.sourceforge.io/releasenotes.html#Release_10.18.0
  • We need to bump to JDK 11 since the new version of checkstyle requires it: checkstyle/checkstyle#9146.
  • Migrate checkstyle xml to remove deprecated properties and add new modules, see:
    • checkstyle/checkstyle#7096
    • checkstyle/checkstyle#6703
  • Made TestFile.java public to trigger the missing javadoc warnings.
  • Bump CodeNarc from 1.4 to 3.5.0 due to class loading issues on JDK 11.
  • This means we also need to bump groovy to 3.0.9.

Jimver avatar Dec 30 '24 14:12 Jimver

This PR depends on #259, as checkstyle also uses saxon net.sf.saxon:Saxon-HE:12.5 like PMD/SpotBugs. Decided to split it up for better readability and to split off the JDK 11 bump into a smaller PR.

Jimver avatar Dec 30 '24 14:12 Jimver

Fixes #262

Jimver avatar Dec 30 '24 15:12 Jimver