nussknacker icon indicating copy to clipboard operation
nussknacker copied to clipboard

Simplified presentation of Nullable/Option/Optional types

Open piotrp opened this issue 4 years ago • 5 comments

Currently these types are displayed on GUI as: plain type (eg. Long, the same as real Long type), Option, Optional.

User shouldn't care about this - things should be optional or not. If possible we should hide Option/Optional from user interface. We could display these types as "{originalType}?", eg. "Long?". That notation could be also used in autocompletion popups to indicate nullability of parameters and returned values.

piotrp avatar Mar 10 '20 12:03 piotrp

This don't need design. It's development case to show Long instead of Option[Long] / Long instead of Optional[Long]. Am I right @Crack?

lciolecki avatar Mar 18 '20 10:03 lciolecki

Do we want to show that a field is mandatory or optional? Do we show "This field is mandatory and can not be empty" just after opening the modal when there is no default value?

witekw avatar Mar 18 '20 10:03 witekw

After opening node details user should be able to identify required fields. We need to visually indicate which fields are required ones. "This field is mandatory and can not be empty" - this red message and red borders around input should not be visible just after opening node. It should appear after validation. We should not validate before user fills the input.

fi- avatar Mar 18 '20 10:03 fi-

@lciolecki IMO we shouldn't handle Option/Optional, Nullable is enough. @fi- has right that we should switch from "punishing logic" because user not filled something to "advising logic", what should be filled.

arkadius avatar Mar 18 '20 11:03 arkadius

I agree with that we should run validation after put something in input or after press save button.

lciolecki avatar Mar 18 '20 12:03 lciolecki