nussknacker icon indicating copy to clipboard operation
nussknacker copied to clipboard

[NU-1479] deployment status endpoint

Open arkadius opened this issue 1 year ago • 2 comments

Describe your changes

Checklist before merge

  • [ ] Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • [ ] Code is cleaned from temporary changes and commented out lines
  • [ ] Parts of the code that are not easy to understand are documented in the code
  • [ ] Changes are covered by automated tests
  • [ ] Showcase in dev-application.conf added to demonstrate the feature
  • [ ] Documentation added or updated
  • [ ] Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • [ ] Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • [ ] Verify that PR will be squashed during merge

arkadius avatar Apr 18 '24 07:04 arkadius

created: #6012 :warning: Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

github-actions[bot] avatar Apr 23 '24 11:04 github-actions[bot]

LGTM but I would wait for the @coutoPL opinion about errors in order to be on the same side in error handling.

lukasz-bigorajski avatar Apr 26 '24 07:04 lukasz-bigorajski

  1. do we need some changelog entry?

We need one changelog entry about experimental batch support. I'll add it in separate PR when I collect all related changes

  1. one missing comment

Fixed

arkadius avatar May 08 '24 19:05 arkadius