Théodore Prévot

Results 79 comments of Théodore Prévot

The PR #395 solves the async adapter issues. However before merging this to the main branch I want to be sure that we have a stable trait for all the...

After considering all the possibilities to solve this issue I came to think that we should simply implement the msgpack parser as an enum based solution. ```rust enum Parser {...

Unfortunately this is the only way I found to handle multi arguments. When multi arguments are received they are "compacted" into an array and to send multi arguments you just...

`serde_json::Value` doesn't make the difference (in both case it is a `Value::Array` variant) and we must support multi arguments to have full compatibility. Solving this issue would require to be...

> Perhaps it would make sense to always require a tuple in `emit()`? You would have to write `socket.emit("single", (value,))` to emit a single argument, which is less pretty, but...

> https://github.com/Totodore/socketioxide/blob/d890ba4040efe5b0376d9a68a20fc20733d96cc8/socketioxide/src/packet.rs#L313-L315 > > ```rust > Value::Array(v) if !v.is_empty() => serde_json::to_string(&vec![ > (*e).to_string(), > serde_json::to_string(v).unwrap(), > ]), > > ``` > > Maybe we can modify it like this. >...

I'm still hesitant on the direction to take to fix this issue. > Tbh I'd still argue for a single emit() method that takes a tuple. On second thought I...

Currently you can't but it is on my to-do list. This issue can serve as a tracking issue for this feature

Hi! The main issue is that there is no standardized way to manage the remote IP between http frameworks. For example, Axum is [storing connect information in `extensions`](https://docs.rs/axum/latest/axum/struct.Router.html#method.into_make_service_with_connect_info) whereas salvo...

As said before, there is no way to do that with socketioxide because it is not included in the tower/hyper spec. The way to get the IP is different between...