TotoGaz

Results 107 comments of TotoGaz

A `meshDoctor` tool has been merged in https://github.com/GEOSX/GEOSX/pull/2091 and could be used to welcome more and more checks. Closing this issue in favor of more precise check needs.

This is a really fruitful analysis, thx @bmhan12 In a nutshell, is it fair to state that we cannot really find real `C++` cycles, but that our `C++` architecture does...

@jhuang2601 @francoishamon So this is not added into the integratedTests, we're OK with this? As a result we do not need to rebaseline.

> @TotoGaz We need to rebaseline as new smoke test is added into integratedTest. But I cannot run it on Quartz and have requested @francoishamon to do it for me....

Oh, OK. I did not see the PR + I could not see the modified `integratedTests` repository modified in the files.

@rrsettgast despite minor doc requirements, I think this is ready to go. Is there anything required on the LLNL side?

@XL64 are you sure it's ready to merge? There are still some questions here and there. Plus some minor doc considerations.

@XL64 can you manage the conflict with `develop`, you're next to be merged.

I think we should rush https://github.com/GEOSX/GEOSX/pull/2025 for immediate relief of our build queues (tick box one). Maybe we can merge it as is and do a better cleaning after?