CloudBot icon indicating copy to clipboard operation
CloudBot copied to clipboard

Format {verb} on display_scores

Open Vault108 opened this issue 2 years ago • 4 comments

Fixes #606

Vault108 avatar Feb 15 '23 05:02 Vault108

Codecov Report

Base: 79.77% // Head: 79.77% // No change to project coverage :thumbsup:

Coverage data is based on head (b4d04fb) compared to base (c46f390). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files         278      278           
  Lines       19377    19377           
  Branches     2250     2250           
=======================================
  Hits        15458    15458           
  Misses       3660     3660           
  Partials      259      259           
Impacted Files Coverage Δ
plugins/duckhunt.py 52.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Feb 15 '23 05:02 codecov[bot]

Please add test cases to ensure this functions as expected

linuxdaemon avatar Apr 23 '23 22:04 linuxdaemon

Please add test cases to ensure this functions as expected

I messaged you on snoonet, how would I go about doing this. Can you point me in the right direction?

Vault108 avatar May 15 '23 02:05 Vault108

Please add test cases to ensure this functions as expected

I messaged you on snoonet, how would I go about doing this. Can you point me in the right direction?

Hey, sorry I haven't replied. You can check out https://github.com/TotallyNotRobots/CloudBot/blob/75399e0c1fa7bee38ce51b6c22c00974a1f9be77/tests/plugin_tests/test_duckhunt.py#L27 which is the current tests for this function. We use the pytest test framework, so you can make the changes locally and then just run python -m pytest to see if they worked. Usually I will write the test, ensure it fails with the current code, and then apply my fix to ensure the test then passes. Make sure to pip install -Ur requirements-dev.txt to install the development dependencies first.

linuxdaemon avatar Mar 13 '24 23:03 linuxdaemon