BookPlayer icon indicating copy to clipboard operation
BookPlayer copied to clipboard

Bug: "Use Remaining Time" feature changes remaining time based on speed multiplier and does not change current timestamp

Open domagoj-tokic opened this issue 1 year ago • 5 comments

Environment

  • OS Version: [e.g. 17.0.3]
  • App Version: [5.0.10-18]

Description

By default "Use Remaining Time" toggle is on. If the value of playback speed multiplier is changed in the middle of track, remaining time will be divided by multiplier value, but current timestamp won't.

Steps to reproduce the behavior

  1. Turn on "Use Remaining Time" toggle
  2. Go in player and set the timer to the middle of track
  3. Change value of track playback speed multiplier
  4. Press play to get update on timestamps

domagoj-tokic avatar Nov 05 '23 17:11 domagoj-tokic

Do you mean the knob position in the progress bar? Because the current time label (the one at the left) should not be affected by the playback speed, as it determines the current time of the book you're at (for example at a paused state, where speed does not matter)

GianniCarlo avatar Nov 05 '23 18:11 GianniCarlo

IMG_5598 IMG_5599

domagoj-tokic avatar Nov 05 '23 20:11 domagoj-tokic

Hope these images help :)

domagoj-tokic avatar Nov 05 '23 20:11 domagoj-tokic

This is interesting, as I think both options make sense, actually. It seems like other AV players I've looked at aren't in agreement here, either. Spotify doesn't update the time remaining when changing speed and showing time remaining:

Screenshot 2023-11-08 at 11 54 04 Screenshot 2023-11-08 at 11 53 56

but mpv does:

1x: Screenshot 2023-11-08 at 11 55 48 2x: Screenshot 2023-11-08 at 11 56 24

(The file in mpv was with time at 0, but moving the time to the middle of the file shows that the current time shows the actual current time in file still, but shows the wall time for remaining time at the current speed - the same behavior as BookPlayer.)

So both options have precedent, and both have advantages and disadvantages. I like showing the remaining wall time, because for odd playback speeds like 1.3, it's not very easy to do the mental math to know how much actual time the file will take to be done at the current speed.

I think this could be an option, "Show remaining time as wall time" or something, but I wouldn't call it a bug. I'm sure @GianniCarlo would be open to a PR for this, or maybe it can be added at some point in the future.

harrisi avatar Nov 08 '23 20:11 harrisi

I would call it a bug because progress and remaining time both aren't changed (or not changed) according to multiplier - that in combination with slider makes it look even more confusing. But I agree, it's personal preference whether to use multiplier to change current timestamp and remaining time or not. Some want to know how long will the track take to play, some take satisfaction from listening to 20min chapter in 10mins using 2x speed and consider it being efficient.

domagoj-tokic avatar Nov 08 '23 21:11 domagoj-tokic