Tormak9970
[BUG]: errors on tabs using EmuDeck collections when restarting Steam
Describe the bug when I have a tab which references a collection - which in my case is populated by EmuDeck, there is a moment in time where the collection does not exist/was not loaded or populated yet, but TabMaster starts up and pops up an error which I can't close until i "fix" it - even though fixing it is futile because the collections already exist. i want to clarify that I don't know if this only specifically happens with EmuDeck collections - but i'm making a guess that this is probably the case.
To Reproduce Steps to reproduce the behavior:
- Find a collection which is created by EmuDeck
- Make a tab which references that collection
- Restart Steam in Game Mode (do not restart the Steam Deck) and hope TabMaster loads before it is created/populated/whatever
- Get an error
Expected behavior there are so many expected behaviors that i would so gladly enjoy:
- take more time before popping up an error
- implement a reload button on the error fix popup
- periodically check if the errors are fixed while the popup is open
- implement an ignore button or be able to close the modal (move the fixer to the plugin settings/tab settings)
Environment Info: can't get right now - i'm in bed playing in docked mode, don't want to get up, and my deck is stuck in a softlock because i restarted Steam and the plugin is holding me hostage . i'll get it later if important. Good night guys
@jessebofill thoughts on this solution:
- Move the fix system to the settings page we were discussing.
- Show a dismissable modal saying effectively "hey you have errors", with a link to settings
@iminlikewithyou in regards to the other notes you made, it doesn't make sense to wait to show the modal, because if something is broken, that gives the user a chance to navigate to the tab and break their library
I'm not sure why the EmuDeck collections don't exist initially, that doesn't seem like a great method for having dynamic collections
@jessebofill thoughts on this solution:
- Move the fix system to the settings page we were discussing.
- Show a dismissable modal saying effectively "hey you have errors", with a link to settings
@iminlikewithyou in regards to the other notes you made, it doesn't make sense to wait to show the modal, because if something is broken, that gives the user a chance to navigate to the tab and break their library
I'm not sure why the EmuDeck collections don't exist initially, that doesn't seem like a great method for having dynamic collections
I don’t see the point to move it do a different page. If the problem is caused by a collection not existing when the check happens then that won’t fix anything, right?
i wouldn't be expecting a user to always be keen on fixing issues with tabs when they just want to open steam and play games and get an undismissable prompt, though. i think you should allow it to be dismissed in some way and simply let those tabs be empty, have a warning symbol on them, etc.
I don’t remember how we handle it but something like that may be a good idea. Ideally though it shouldn’t detect an error every time steam loads, and should only happen if a collection actually got deleted. We’ll have to look in why the collection doesn’t exist initially. Did you say it’s a dynamic collection? How does emu deck manage these collections? I’ve never used it.
i'm not 100% sure how it manages collections, but they seem to be injected, rather than actual permanent collections? there are times that EmuDeck never even makes the collections when Steam loads (this is just due to an EmuDeck bug - maybe it tries to create them before Steam is actually loaded and it errors). in any case, this causes there to be no automatically generated collections from EmuDeck and can be frustrating when TabMaster nags about it.
because of this behavior, TabMaster can throw errors since it may load before EmuDeck has even generated the collections, or because EmuDeck never created the collections in the first place.
Ah if that’s the case, it sounds more like an emu deck issue, rather than tab master. I understand that tab master will show that notification, but that’s how we designed it. If emu deck is doing some abnormal way of creating collections then I feel like it’s an unfortunate incompatibility with tab master. I’m curious do those collections show up across different steam devices?
Ah if that’s the case, it sounds more like an emu deck issue, rather than tab master. I understand that tab master will show that notification, but that’s how we designed it. If emu deck is doing some abnormal way of creating collections then I feel like it’s an unfortunate incompatibility with tab master. I’m curious do those collections show up across different steam devices?
They only show up on other devices if the device is booted up, they're stored locally on the device
Ah if that’s the case, it sounds more like an emu deck issue, rather than tab master. I understand that tab master will show that notification, but that’s how we designed it. If emu deck is doing some abnormal way of creating collections then I feel like it’s an unfortunate incompatibility with tab master. I’m curious do those collections show up across different steam devices?
They only show up on other devices if the device is booted up, they're stored locally on the device
That’s what I thought
Given this is an issue on EmuDeck's side, perhaps you can mention it there, but for now, I'm going to close it as its not related to how TabMaster is written