ToolJet icon indicating copy to clipboard operation
ToolJet copied to clipboard
Published 3 months ago • verified publisher icon ToolJet

[dark mode] fix color of time selection box in datepicker

Open withshubh opened this issue 2 years ago • 21 comments

What is the current behaviour?

In dark mode, the color of the time selection box in datepicker should be dark.

How to reproduce the issue?

  1. Switch to dark mode
  2. drag a datepicker
  3. enable time selection from datepicker property
  4. Check the color of the Time selection box

Screenshots or Screencast

Screenshot 2023-05-05 at 6 00 14 PM

withshubh avatar May 05 '23 13:05 withshubh

I would like to work on this issue

wxomi avatar May 05 '23 13:05 wxomi

I too can work on this.

JayeshJanyani avatar May 05 '23 14:05 JayeshJanyani

The selection items are all white background. Should be make dark themed.

image

Sheikh-JamirAlam avatar May 05 '23 16:05 Sheikh-JamirAlam

Hey, i would like to work on this issue

PrasannaBH avatar May 06 '23 16:05 PrasannaBH

@withshubh Came up with this. Unfornately I don't think it is possible to edit the color for the clock icon in the time section. image

Sheikh-JamirAlam avatar May 06 '23 17:05 Sheikh-JamirAlam

@withshubh @Sheikh-JamirAlam i pulled the latest code and made changes but i cant see the the clock image that is present in your screenshot

Screenshot from 2023-05-06 23-38-03

PrasannaBH avatar May 06 '23 18:05 PrasannaBH

@PrasannaBH That's weird. I also pulled the latest repo only.

Sheikh-JamirAlam avatar May 06 '23 18:05 Sheikh-JamirAlam

Hey @wxomi - Thanks for showing interest in contributing to ToolJet. Assigned the issue to you.

withshubh avatar May 08 '23 06:05 withshubh

@PrasannaBH That's weird. I also pulled the latest repo only.

@Sheikh-JamirAlam Which branch are you using ? I am using the develop branch

PrasannaBH avatar May 20 '23 05:05 PrasannaBH

Hey @withshubh can you please assign this to me nobody is working. I can make PR for this issue

PrasannaBH avatar May 24 '23 14:05 PrasannaBH

Hey @wxomi - Any updates on the PR?

withshubh avatar May 25 '23 07:05 withshubh

@withshubh Please assign me.

iSatVeerSingh avatar Jun 04 '23 02:06 iSatVeerSingh

Hi @JayeshJanyani - Are you still interested in picking up this issue?

withshubh avatar Jun 07 '23 06:06 withshubh

@withshubh Sure

JayeshJanyani avatar Jun 08 '23 15:06 JayeshJanyani

@JayeshJanyani - Thanks for showing interest. Assigned to you.

withshubh avatar Jun 12 '23 07:06 withshubh

Hey @JayeshJanyani - Any updates on the PR?

withshubh avatar Jun 21 '23 11:06 withshubh

Hey @JayeshJanyani - Any updates on the PR?

@withshubh Can you please assign it to someone else, as I am a bit occupied with another issue. Thanks in advance.

JayeshJanyani avatar Jun 24 '23 14:06 JayeshJanyani

@withshubh Can you please check my PR?

iSatVeerSingh avatar Jun 24 '23 14:06 iSatVeerSingh

@karan-rathod-316 Please assign me if its still open .

atharvnaik1 avatar Apr 17 '24 10:04 atharvnaik1

Hi @atharvnaik1,

Assigning this to you. Happy coding:-)

karan-rathod-316 avatar Apr 19 '24 12:04 karan-rathod-316

Implemented changes in theme.scss and respective files input.react-datepicker-time__input background color from white to dark mode. Updated the time popper for dark theme. #9581

atharvnaik1 avatar May 01 '24 20:05 atharvnaik1