ToolJet icon indicating copy to clipboard operation
ToolJet copied to clipboard

Published 20 hours ago • verified publisher icon ToolJet

Fixed version name sanitization on editing versions

Open surajrane42 opened this issue 2 years ago • 12 comments

Resolves #4486

surajrane42 avatar Oct 23 '22 07:10 surajrane42

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 23 '22 07:10 CLAassistant

deployed https://tj-4570.herokuapp.com/

gsmithun4 avatar Oct 24 '22 14:10 gsmithun4

@surajrane42 Please sign the CLA

gsmithun4 avatar Oct 24 '22 14:10 gsmithun4

@surajrane42 Please fix the lint errors and test cases

gsmithun4 avatar Oct 24 '22 17:10 gsmithun4

@gsmithun4 Signed the CLA & fixed linting errors. Please check

surajrane42 avatar Oct 25 '22 14:10 surajrane42

@gsmithun4 @arpitnath I have tried fixing the e2e tests. Can you please check now

surajrane42 avatar Oct 30 '22 06:10 surajrane42

@surajrane42 Please rebase https://github.com/surajrane42/ToolJet/pull/1

gsmithun4 avatar Oct 31 '22 11:10 gsmithun4

@gsmithun4 Rebased the branch. Please check

surajrane42 avatar Oct 31 '22 17:10 surajrane42

@surajrane42 There is a testcases failing, please fix

gsmithun4 avatar Nov 02 '22 14:11 gsmithun4

@gsmithun4 Sure I will have a look at it & fix it soon

surajrane42 avatar Nov 02 '22 16:11 surajrane42

Hey @surajrane42
Thanks for contributing to ToolJet. :raised_hands: While this PR is under review, you can submit the form to claim your Hacktoberfest swag: https://airtable.com/shr1qR6xhqsWO7LD7

withshubh avatar Nov 14 '22 09:11 withshubh

Hey @surajrane42 - Please make the changes suggested by @gsmithun4 so that we can review and merge the PR.

withshubh avatar Dec 12 '22 09:12 withshubh

Deployment: https://tooljet-pr-4570.onrender.com Dashboard: https://dashboard.render.com/web/srv-cfksllha6gductgm1p90

github-actions[bot] avatar Feb 13 '23 05:02 github-actions[bot]

Deployment: https://tooljet-pr-4570.onrender.com Dashboard: https://dashboard.render.com/web/srv-cfku8dla49903fhuspsg

github-actions[bot] avatar Feb 13 '23 07:02 github-actions[bot]