ToolJet icon indicating copy to clipboard operation
ToolJet copied to clipboard

Add validation for group creation

Open ajith-k-v opened this issue 2 years ago • 11 comments

What is the expected behaviour?

The group should have a valid name.

What is the current behaviour?

The user can create groups with the group name as a blank space.

How to reproduce the issue?

Video

Screenshots or Screencast

Screenshot 2022-05-27 at 10 32 13 PM

Any possible solutions?

Add validations.

ajith-k-v avatar May 27 '22 17:05 ajith-k-v

Hi @ajith-k-v, I'd like to work on this issue. can you assign me?

mazkaaa avatar May 27 '22 17:05 mazkaaa

@mazkaaa Assigned the issue to you.

ajith-k-v avatar May 28 '22 01:05 ajith-k-v

Hey @mazkaaa 👋 Any updates on this issue?

withshubh avatar Jun 20 '22 19:06 withshubh

Hey @mazkaaa 👋 Any updates on this issue?

Hi, sorry I don't see the assigned notification. will work on this issue right away

mazkaaa avatar Jun 21 '22 02:06 mazkaaa

No worries! Thanks for the update @mazkaaa 👍 Do link this issue to the PR when you create it.

withshubh avatar Jun 21 '22 06:06 withshubh

No worries! Thanks for the update @mazkaaa 👍 Do link this issue to the PR when you create it.

The current code in this group creation js file is using the class component. Should I change the whole code to the functional component?

mazkaaa avatar Jun 23 '22 17:06 mazkaaa

Hey @mazkaaa, refactoring will increase the scope of the change. Let's keep it simple to add a validation check both at frontend and backend dto to not allow whitespaces.

akshaysasidrn avatar Jun 24 '22 06:06 akshaysasidrn

Hey @mazkaaa, refactoring will increase the scope of the change. Let's keep it simple to add a validation check both at frontend and backend dto to not allow whitespaces.

Okay. i still working on it sorry if its late almost 1 months because i've been sick because of covid.

mazkaaa avatar Jul 05 '22 04:07 mazkaaa

Hey @mazkaaa

There are a few changes requested in the PR. Kindly resolve it so that we close the issue soon.

shivangT avatar Sep 15 '22 05:09 shivangT

Hey @mazkaaa

There are a few changes requested in the PR. Kindly resolve it so that we close the issue soon.

ohh sorry! will working on it!

mazkaaa avatar Sep 15 '22 10:09 mazkaaa

Thanks

shivangT avatar Sep 15 '22 11:09 shivangT

This issue no longer exists.

ajith-k-v avatar Oct 03 '22 05:10 ajith-k-v