ToolJet
ToolJet copied to clipboard
Add validation for group creation
What is the expected behaviour?
The group should have a valid name.
What is the current behaviour?
The user can create groups with the group name as a blank space.
How to reproduce the issue?
Screenshots or Screencast

Any possible solutions?
Add validations.
Hi @ajith-k-v, I'd like to work on this issue. can you assign me?
@mazkaaa Assigned the issue to you.
Hey @mazkaaa 👋 Any updates on this issue?
Hey @mazkaaa 👋 Any updates on this issue?
Hi, sorry I don't see the assigned notification. will work on this issue right away
No worries! Thanks for the update @mazkaaa 👍 Do link this issue to the PR when you create it.
No worries! Thanks for the update @mazkaaa 👍 Do link this issue to the PR when you create it.
The current code in this group creation js file is using the class component. Should I change the whole code to the functional component?
Hey @mazkaaa, refactoring will increase the scope of the change. Let's keep it simple to add a validation check both at frontend and backend dto to not allow whitespaces.
Hey @mazkaaa, refactoring will increase the scope of the change. Let's keep it simple to add a validation check both at frontend and backend dto to not allow whitespaces.
Okay. i still working on it sorry if its late almost 1 months because i've been sick because of covid.
Hey @mazkaaa
There are a few changes requested in the PR. Kindly resolve it so that we close the issue soon.
Hey @mazkaaa
There are a few changes requested in the PR. Kindly resolve it so that we close the issue soon.
ohh sorry! will working on it!
Thanks
This issue no longer exists.