ToolJet icon indicating copy to clipboard operation
ToolJet copied to clipboard

chore: Exposes CSAs for Container widget

Open nithindavid opened this issue 1 year ago • 7 comments

Changes made

  • Added state variables to keep track of the loading, disabled and visibility
  • Publishes the attributes through setExposedVariable, setExposedVariables
image

Issue: #11147

Note: Reset Container is not implemented

nithindavid avatar Nov 06 '24 13:11 nithindavid

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Nov 06 '24 13:11 TooljetBot

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Nov 08 '24 05:11 TooljetBot

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Nov 14 '24 17:11 TooljetBot

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Nov 15 '24 05:11 TooljetBot

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Nov 15 '24 07:11 TooljetBot

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Nov 22 '24 10:11 TooljetBot

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Nov 27 '24 19:11 TooljetBot

Quality Gate Failed Quality Gate failed

Failed conditions
59.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Nov 29 '24 14:11 sonarqubecloud[bot]

Code Review Agent Run #ef1a79

Actionable Suggestions - 7
  • server/src/helpers/widget-config/container.js - 1
    • Consider consolidating duplicate state properties · Line 102-103
  • frontend/src/Editor/WidgetManager/configs/container.js - 3
    • Missing validation for disabled state property · Line 33-36
    • Consider removing duplicate setLoading action · Line 89-92
    • Consider removing duplicate disabledState property · Line 103-103
  • frontend/src/AppBuilder/WidgetManager/widgets/container.js - 3
    • Consider consolidating similar toggle properties · Line 18-36
    • Consider renaming visibility parameter for clarity · Line 80-82
    • Consider renaming parameter handle for clarity · Line 84-87
Additional Suggestions - 3
  • server/src/helpers/widget-config/container.js - 2
    • Consider direct boolean for default value · Line 82-82
    • Consider consolidating similar toggle configurations · Line 18-36
  • frontend/src/AppBuilder/_hooks/useExposeVariables.js - 1
    • Align function name with file name · Line 3-3
Review Details
  • Files reviewed - 6 · Commit Range: 8eb10fa..a26efe3
    • frontend/src/AppBuilder/RightSideBar/Inspector/Components/DefaultComponent.jsx
    • frontend/src/AppBuilder/WidgetManager/widgets/container.js
    • frontend/src/AppBuilder/Widgets/Container.jsx
    • frontend/src/AppBuilder/_hooks/useExposeVariables.js
    • frontend/src/Editor/WidgetManager/configs/container.js
    • server/src/helpers/widget-config/container.js
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful

AI Code Review powered by Bito Logo

TooljetBot avatar Nov 29 '24 15:11 TooljetBot

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - Container Widget Enhancement

- DefaultComponent.jsx - Added 'Container' to the component list

- container.js - Updated container configuration with new properties and actions

- Container.jsx - Refactored Container component to use new state management

- useExposeVariables.js - Added new hook for managing exposed variables

- container.js - Updated container configuration in the editor

- container.js - Updated server-side container configuration

TooljetBot avatar Nov 29 '24 15:11 TooljetBot