ToolJet icon indicating copy to clipboard operation
ToolJet copied to clipboard

[docs]: Fix documentation for the Date Picker Component

Open Swapnil-2502 opened this issue 1 year ago • 11 comments

This PR is for #11177

Summary:

The entire URL of the documentation with the issue

https://docs.tooljet.com/docs/widgets/datepicker

Content updates:

In the Event Table, update the "Description" for the given event reference ( Please just check the sentence structure from the given reference ) In Exposed variable Table, update the "Description" and "How To Access" for the given action reference ( Please just check the sentence structure from the given reference ) Layout Table Update the title name from "Layout" to "Devices" reference Update the name of the first column from "Layout" to "Property" Update the content in the "Description" and "Expected value" columns as per the given reference ( Please just check the sentence structure from the given reference ) Add a full stop at the end of the sentence in the "Description" and "Expected value" columns.

The changes are to be implemented in two files - Next - ToolJet/docs/docs/widgets/datepicker.md Version 2.50.0 (LTS) - ToolJet/docs/versioned_docs/version-2.50.0-LTS/widgets/datepicker.md

Note: Please review this PR and let me know if further changes are needed. Thank you.

Swapnil-2502 avatar Nov 01 '24 12:11 Swapnil-2502

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 01 '24 12:11 CLAassistant

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Nov 01 '24 12:11 TooljetBot

Hey @Swapnil-2502, can you please let us know if you are still working on this PR? Or if you are facing any issue then feel free to drop your query in our Slack community.

RudraPratik30 avatar Nov 07 '24 05:11 RudraPratik30

Yes, I am working on it. I will ask in case of any query.

Swapnil-2502 avatar Nov 07 '24 05:11 Swapnil-2502

@RudraPratik30

This is what expected (Ignore CSS here) Screenshot 2024-11-07 at 3 27 33 PM

And this is the reference Screenshot 2024-11-07 at 3 02 15 PM

This is what I think needs to be done please verify and this will be exactly similar to the given reference, after which I will commit the changes in both the files.

Swapnil-2502 avatar Nov 07 '24 09:11 Swapnil-2502

Hey @Swapnil-2502, Yes the screenshot looks correct to me, other than this you have to make some changes in the event table as well, as mentioned in the issue, make sure to push all the changes in both versions in a single PR, thanks again!

RudraPratik30 avatar Nov 07 '24 12:11 RudraPratik30

Hi @RudraPratik30, I have updated the changes. If there are still changes to be made, I will be sorry for it. Please have a look and let me know.

Swapnil-2502 avatar Nov 07 '24 14:11 Swapnil-2502

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

TooljetBot avatar Nov 07 '24 16:11 TooljetBot

Deployment: https://tooljet-pr-11207.onrender.com Dashboard: https://dashboard.render.com/static/srv-csmqaiqj1k6c73dmq7mg

github-actions[bot] avatar Nov 08 '24 05:11 github-actions[bot]

Hey @Swapnil-2502, thanks for contributing! The changes look good to me and forwarding it to the team for final review. Your PR will be merged soon, thanks again!

Thank you for your time.

Swapnil-2502 avatar Nov 08 '24 06:11 Swapnil-2502