ToolJet icon indicating copy to clipboard operation
ToolJet copied to clipboard

Feature/storybook text area

Open devanshu052000 opened this issue 1 year ago • 9 comments

All the design system components except Codehinter

devanshu052000 avatar Jul 05 '24 06:07 devanshu052000

Code Review Agent Run #3d2dae

  • AI Based Review: ✔️ Successful

Code Review Overview

  • Summary: This PR introduces new components and utilities for file uploading and tooltips, including SVG icons for various file types, validation icons, and customizable input components. Enhancements focus on modularity, maintainability, and performance improvements.
  • Files: 55
  • Issue found: Total - 19, High importance - 19      See detailed feedback ->
  • Code change type: Refactoring, Feature Addition, Performance Improvement, Code Structure
  • Unit tests added: False
  • Estimated effort to review (1-5, lower is better): 5

High-level Feedback

Ensure consistent handling of unsupported file types and optimize SVG usage by extracting common parts into reusable components. Remove unnecessary console logs to avoid performance issues and potential exposure of sensitive data. Validate and sanitize inputs to prevent security risks, and consider using memoization to prevent unnecessary re-renders. Adjust filter dimensions to match SVG elements and use default values for CSS variables to ensure consistent rendering.

Detailed Feedback

:page_facing_up: frontend/src/components/ui/FileUploader/FileUploaderUtils/FileTypeIcons.jsx
Issues: Total - 5, High importance - 5
Line 30-30 🔴 High importance - 1   
Line 196-197 🔴 High importance - 1   
Line 409-592 🔴 High importance - 1   
Line 624-842 🔴 High importance - 1   
Line 874-877 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/Checkbox/CheckboxUtils/IntermediateIcon.jsx
Issues: Total - 1, High importance - 1
Line 4-4 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/FileUploader/FileUploaderUtils/FileUploaderUtils.jsx
Issues: Total - 1, High importance - 1
Line 136-136 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/Switch/Switch.jsx
Issues: Total - 1, High importance - 1
Line 33-33 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/ListItems/ListItemsUtils/ListItemsUtils.jsx
Issues: Total - 1, High importance - 1
Line 36-36 🔴 High importance - 1   
:page_facing_up: frontend/src/Editor/Header/GlobalSettings.jsx
Issues: Total - 1, High importance - 1
Line 175-175 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/FileUploader/FileUpload/FileUpload.jsx
Issues: Total - 2, High importance - 2
Line 25-25 🔴 High importance - 1   
Line 36-36 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/Input/InputUtils/TrailingBtn.jsx
Issues: Total - 1, High importance - 1
Line 23-23 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/Tooltip/TooltipUtils/Arrow.jsx
Issues: Total - 1, High importance - 1
Line 3-3 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/Checkbox/CheckboxUtils/RadioIcon.jsx
Issues: Total - 1, High importance - 1
Line 4-4 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/Input/CommonInput/NumberInput.jsx
Issues: Total - 1, High importance - 1
Line 32-33 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/Input/EditableTitleInput/Index.jsx
Issues: Total - 1, High importance - 1
Line 29-33 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/Text Area/TextareaUtils/ValidationIcon.jsx
Issues: Total - 1, High importance - 1
Line 4-4 🔴 High importance - 1   
:page_facing_up: frontend/src/components/ui/Text Area/Textarea.jsx
Issues: Total - 1, High importance - 1
Line 12-12 🔴 High importance - 1   

AI Code Review powered by Bito Logo

TooljetBot avatar Jul 05 '24 06:07 TooljetBot

Deploy Preview for tooljet-storybook ready!

Name Link
Latest commit b3f667249afc9d1168b5a3f9031a96507c6951a6
Latest deploy log https://app.netlify.com/sites/tooljet-storybook/deploys/66b2061f501d680008da6b37
Deploy Preview https://deploy-preview-10279--tooljet-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 05 '24 10:07 netlify[bot]

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

socket-security[bot] avatar Jul 09 '24 07:07 socket-security[bot]

Deployment: https://tooljet-pr-10279.onrender.com Dashboard: https://dashboard.render.com/web/srv-cqgd53l6l47c73bta8lg

github-actions[bot] avatar Jul 24 '24 10:07 github-actions[bot]

Deployment: https://tooljet-pr-10279.onrender.com Dashboard: https://dashboard.render.com/web/null

github-actions[bot] avatar Jul 24 '24 10:07 github-actions[bot]

Deployment: https://tooljet-pr-10279.onrender.com Dashboard: https://dashboard.render.com/web/null

github-actions[bot] avatar Jul 26 '24 07:07 github-actions[bot]

Deployment: https://tooljet-pr-10279.onrender.com Dashboard: https://dashboard.render.com/web/null

github-actions[bot] avatar Jul 29 '24 04:07 github-actions[bot]

Deployment: https://tooljet-pr-10279.onrender.com Dashboard: https://dashboard.render.com/web/null

github-actions[bot] avatar Aug 01 '24 06:08 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Aug 06 '24 11:08 sonarqubecloud[bot]