proxy-agents icon indicating copy to clipboard operation
proxy-agents copied to clipboard

Add support for mTLS

Open mg-dd opened this issue 1 year ago • 15 comments

This PR fixes two issues:

https://github.com/TooTallNate/proxy-agents/issues/194 https://github.com/TooTallNate/proxy-agents/issues/234

The background is that the TLS connection established by the proxy agents do not add the required parameters for mTLS / self-signed CAs. This PR adds a way to provide these parameters. The general approach was taken from the feedback from this PR: https://github.com/TooTallNate/proxy-agents/pull/195/files

ptal @TooTallNate

mg-dd avatar Aug 22 '23 02:08 mg-dd

🦋 Changeset detected

Latest commit: 041a7c52dd9088a58aff8e84a79451c167c0d4a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
https-proxy-agent Minor
socks-proxy-agent Minor
agent-base Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 22 '23 02:08 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Sep 4, 2023 9:13am

vercel[bot] avatar Aug 22 '23 02:08 vercel[bot]

@mg-dd Great PR! I need something similar, do you need any help pushing this over the finish line?

patrickheeney avatar Aug 29 '23 03:08 patrickheeney

@TooTallNate this is ready for another look. The only open question is how you would like to handle the TLS connection in pac-proxy-agent.

mg-dd avatar Aug 29 '23 07:08 mg-dd

Hi, any news on this? I also need this feature.

brunobastosg avatar Sep 26 '23 12:09 brunobastosg

Any news on this?

amirbilu avatar Oct 04 '23 09:10 amirbilu

@TooTallNate: Would love to see this feature in the proxy agents. Is there anything left to do?

cptRaclette avatar Oct 22 '23 14:10 cptRaclette

HI, any update about this PR ? 💯

ErwanRaulo avatar Dec 28 '23 16:12 ErwanRaulo

Thank you soo much for maintaining this awesome project ! Any news ?

marcchambon avatar Jan 22 '24 09:01 marcchambon

can we move forward on this?

what is missing?

sibelius avatar Jan 23 '24 14:01 sibelius

Thank you for this PR ! @TooTallNate Any news about moving forward ?

🙏 🙏

pebie avatar Feb 01 '24 11:02 pebie

we are using a patch of this pull request in production and it is working well

sibelius avatar Apr 01 '24 20:04 sibelius

Hello, is there news about this ? We need it ! :) @TooTallNate

NasGldn avatar Jun 14 '24 08:06 NasGldn

Any plans to get it merged?

szubster avatar Jul 16 '24 15:07 szubster

This would be really helpful.

marcotranchino avatar Aug 08 '24 17:08 marcotranchino