Mime-Detective-clarkis117 icon indicating copy to clipboard operation
Mime-Detective-clarkis117 copied to clipboard

Add more framework targets

Open marko444 opened this issue 6 years ago • 3 comments

Your current targets are: <TargetFrameworks>netstandard1.3;net45</TargetFrameworks>

Would it be possible to add also net471, netstandard2.0 ?

I tried including your latest beta nuget into my net471 project and got some unexpected warnings. Warning Found conflicts between different versions of "System.Net.Http" that could not be resolved. These reference conflicts are listed in the build log when log verbosity is set to detailed. Dependencies System.Buffers and System.Xml.XmlSerializer both got included but they shouldn't?

marko444 avatar May 25 '18 08:05 marko444

Are you referencing the HttpClient nuget package or the one in full framework? 🤔

clarkis117 avatar May 25 '18 12:05 clarkis117

@marko444 generally just adding more targets to a project is a bad practice. Could you provide a list of references in your project and their versions? (so I can repro this) In addition, this library doesn't reference System.Net.Http at all.

Both System.Buffers and System.Xml.XmlSerializer are currently required for all projects. System.Buffers hasn't been included in full framework yet; however, I'm thinking about dropping the System.Xml.Serializer dependency.

<ItemGroup> <PackageReference Include="System.Buffers" Version="4.4.0" /> <PackageReference Include="System.Xml.XmlSerializer" Version="4.3.0" /> </ItemGroup>

clarkis117 avatar May 26 '18 00:05 clarkis117

@marko444 There's some new guidance since netstandard1.6 is now depreciated, so I'm going to update this weekend to multi-target.

clarkis117 avatar Apr 12 '19 02:04 clarkis117