CIL icon indicating copy to clipboard operation
CIL copied to clipboard

Power method tolerance 1e-5 should be smaller

Open MargaretDuff opened this issue 1 year ago • 1 comments

Description

The default tolerance for the power method, used to calculate the norm of linear operators, is set to 1e-5. This is used when deciding if the calculated norm is small enough to be assumed to be zero and prevents the algorithm from diverging by dividing by zero.

https://github.com/TomographicImaging/CIL/blob/5d569dc054759a8c137ca72611fc7be07be6080e/Wrappers/Python/cil/optimisation/operators/Operator.py#L339-L345

@bosschmidt found that this incorrectly returned his operator's norm to zero, and setting the tolerance to 1e-8 eventually led to the power method calculating a correct non-zero norm value.

Perhaps this tolerance needs re-thinking.

MargaretDuff avatar Nov 08 '24 13:11 MargaretDuff

We will investigate this but in the meantime we should at least change the warning

MargaretDuff avatar Nov 14 '24 13:11 MargaretDuff