CIL icon indicating copy to clipboard operation
CIL copied to clipboard

Dataexample update

Open hrobarts opened this issue 1 year ago • 0 comments

Changes

Use zenodo_get for the data download and validation

Testing you performed

Updated download_data tests

  • Mock zip file when zenodo_get is called
  • Create the mock zip file in the CIL data folder rather than tmp folder because we don't always have access to unzip files in the tmp folder

Related issues/links

depends on https://github.com/dvolgyes/zenodo_get/pull/25

Checklist

  • [x] I have performed a self-review of my code
  • [x] I have added docstrings in line with the guidance in the developer guide
  • [x] I have updated the relevant documentation
  • [x] I have implemented unit tests that cover any new or modified functionality
  • [x] CHANGELOG.md has been updated with any functionality change
  • [x] Request review from all relevant developers
  • [x] Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • [x] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • [x] I confirm that the contribution does not violate any intellectual property rights of third parties

hrobarts avatar Apr 11 '24 12:04 hrobarts