CCPi-Regularisation-Toolkit icon indicating copy to clipboard operation
CCPi-Regularisation-Toolkit copied to clipboard

Create virtual algorithm class and concrete algorithm classes

Open paskino opened this issue 5 years ago • 3 comments

Currently the algorithms used in the toolkit are repeated within the different functions. This code repetition may lead to error.

Let's create an iterative algorithm class with the same structure of the Algorithm in the Framework.

paskino avatar Mar 18 '19 11:03 paskino

I assume this means wrapping C/CUDA functions into C++ classes? Is it possible or one needs to change C syntax to C++ ?

dkazanc avatar Mar 18 '19 11:03 dkazanc

possibly the largest change should be adding extern "C" to function definitions on the C++ code.

The main idea is to use the existing functions you developed in C/CUDA, not rewriting them. The object orientated structure should significantly reduce duplication of code.

paskino avatar Mar 18 '19 14:03 paskino

makes sense. Happy to support this where I can.

dkazanc avatar Mar 18 '19 15:03 dkazanc