CCPi-Regularisation-Toolkit

CCPi-Regularisation-Toolkit copied to clipboard

Issue with 3D GPU regularisers in v. 24.0.0

3

Thanks a lot for refactoring guys! While I was fiddling with the toolkit to make it work for ToMoBAR, I noticed that the output volumes in `demo_gpu_regularisers3D.py` are not good...

dkazanc

Adding tests with pytest

4

CuPy requires for CUDA kernels to be present during the build. I've modified the `build.sh` and `bld.bat` files to do that. @paskino A question about a CuPy dependency. It can...

dkazanc

ctypes: pass the dimension parameters in the correct order

2

The dimension parameter in v24.0.0 is passed reversed to what it was in version v22.0.0, see details below for `FGP_TV`. In this PR, we invert the `dims` list at creation...

paskino

pip install

1

vis. https://github.com/AMYPAD/CuVec - [ ] move `pyproject.toml` to root - [ ] `scikit-build-core` - [ ] `setuptools_scm` - [ ] update docs - [ ] release on PyPI - [...

casperdcl

- [x] add CUDA builds (#196) - [x] add windows CPU build & test (#203) - [ ] add windows GPU build - [ ] add conda release token +...

casperdcl

Discontinue MATLAB support

1

The MATLAB extension is not supported and has not changed in the last 5 years. it will be removed.

paskino

Since CMake 3.10 `FindCUDA` is deprecated and we should use `project(LANGUAGES)`

paskino

With the work on the ctypes #183 I encountered a problem with the comparison of TGV CPU and GPU implementations. There is a minor difference at the start of the...

paskino

adding python 3.7 to the CI build

2

dkazanc

The `PATCHSEL_CPU` function only works for 2D data, although a function for 3D seems to be [implemented](https://github.com/vais-ral/CCPi-Regularisation-Toolkit/blob/71f8d304d804b54d378f0ed05539f01aaaf13758/src/Core/regularisers_CPU/PatchSelect_core.c#L62-L107) in the C library. https://github.com/vais-ral/CCPi-Regularisation-Toolkit/blob/71f8d304d804b54d378f0ed05539f01aaaf13758/src/Python/src/cpu_regularisers.pyx#L608-L612

paskino