tttdamagelogs icon indicating copy to clipboard operation
tttdamagelogs copied to clipboard

Roles are Sometimes Incorrect

Open TheFate opened this issue 4 years ago • 1 comments

Sometimes, the damagelog will pull incorrect roles for the logs. image

As you can see in reality, those players were both innocents, not a traitor and a detective: image

Some incorrect method must be pulling data from either the incorrect round or somehow some calculation is getting offset. The odd thing about this issue is that it does not happen for everyone, only some players during some rounds. It is very inconsistent and happens about once every 5 rounds to 1-2+ players.

This is consistent in both the RDM manager damagelog and the regular damagelog.

This is with an unmodified version of TTT with no custom roles. If anyone has any prior experience with fixing this issue please let me know since it looks like this is not actively maintained by the official developer.

This is a very serious issue given the entire point of this addon is to review the damagelogs for RDMs. This confuses staff and makes reports impossible to handle when we cannot consistently trust that the roles are correct in the damagelog.

TheFate avatar Apr 06 '20 23:04 TheFate

It think this is caused by Damagelogs not retrieving a cached role from attacker/victim, but their current ones.

Can you verify by checking if the roles shown in the "Logs before" are the roles of the players at the time of viewing?

Edit: Nevermind. After more searching, I found that each player's data is cached in Damagelog.Roles at the start of every round.

iViscosity avatar Apr 07 '20 07:04 iViscosity