tttdamagelogs icon indicating copy to clipboard operation
tttdamagelogs copied to clipboard

Damagelog some Events(damage,killed etc) are not shown?

Open Alabama4 opened this issue 7 years ago • 13 comments

Hey, i recently ran into a Problem where some events are not shown for example if you kill yourself its not shown/ damage yourself, if you die by a prop its not shown anymore, if you die by a headcrablauncher its not shown and a few more, i believe its since the update 3.00, could anyone help me out with fixing that? :)

Regards

Alabama4 avatar Dec 30 '17 01:12 Alabama4

Confirmed. I will look into all I can find.

Currently known (and fixed?):

  • [x] prop (fixed with https://github.com/Tommy228/TTTDamagelogs/commit/4a603dbb08a0a9212db3e2d3e9144f7282128ce7#diff-7635be68d866796324995b795a00fe8a and https://github.com/Tommy228/TTTDamagelogs/commit/3be4baca5d02c29dd84326a1217b7d68ce13a0f4)
  • [ ] headcrablauncher
  • [ ] fire (using a flaregun on an entity that burns you)

MinIsMin avatar Dec 30 '17 10:12 MinIsMin

Hey, thanks for the fast reply, but i've tried the prop fix, it still does not seem to work, i've download the newest version, where you already invented the lines & it didnt seem to show any kills in the manager, (i've tried it with Bots & on singleplayer), and is there any reason to remove Water damage?, because if you drown its not shown either

Regards

Alabama4 avatar Dec 30 '17 11:12 Alabama4

There are many changes between 3.0 and the current master version which may not work. The fix for propkills checked for prop_physics but now also checks for func_physbox and should be fully working now. Drownings are seperated to it's own event: events/drownings.lua

MinIsMin avatar Dec 30 '17 12:12 MinIsMin

Ok i see, thanks :), would it be possible if you could add a event which is caused when a player pushes another player with a crowbar 4 example?, i tried doing it myself but didnt really get behind it :D

Alabama4 avatar Dec 30 '17 12:12 Alabama4

I will look into readding it, some code is already there: https://github.com/Tommy228/TTTDamagelogs/blob/5c0408d66668f1b9e8dd1b7b1bd4dff6095211cb/lua/damagelogs/client/listview.lua#L280-L283

MinIsMin avatar Dec 30 '17 12:12 MinIsMin

Is it better to upload the old Damagelog for now?[where everything shows i think] (if yes where could i get it) or just wait until it gets fixed? [

Alabama4 avatar Dec 31 '17 10:12 Alabama4

You can get the old (2.4.0 with one exploit fix) version from here: https://github.com/Tommy228/TTTDamagelogs/archive/fafffdd6903c05b8c27d4de0764783e82abd68fc.zip You need to know for yourself if you want to use the old or new version. We will try to fix all bugs and issues and then release a new, stable version (no ETA yet).

MinIsMin avatar Dec 31 '17 10:12 MinIsMin

Ok thanks, also another question:

Is it possible to add a Damagelog line without creating its own event for it? for example with handcuffs:

Player a handcuffed player b (add a line into Primaryattack like: Damagelog:AddLine(Player a put Player B into Handcuffs) ?

Regards

Alabama4 avatar Jan 01 '18 18:01 Alabama4

I don't think so, because every log entry is tied to an event (and uses event:ToString() method to actually get the line in text to display). Creating an event shouldn't be very hard though.

P.S. I might be wrong on this

iagrib avatar Jan 02 '18 11:01 iagrib

iagrib is right, you need a damagelog event since it manages e.g. the hooks, colors, text formatting and user stuff like Highlight and RightClick.

Please be aware to the actual topic of this issue, so other contributers can keep better track of the missing events.

MinIsMin avatar Jan 02 '18 12:01 MinIsMin

Oh ok sorry my bad :P, was just a question ^_^

Alabama4 avatar Jan 02 '18 12:01 Alabama4

Hey i also just noticed that if you die by lava on minecraft_ttt_b5 youre not in the logs that you died(not sure if already fixed)

Alabama4 avatar Jan 06 '18 10:01 Alabama4

Using the newest master version, dying in lava is already recorded by events/suicide.lua.

MinIsMin avatar Jan 06 '18 11:01 MinIsMin