A few bugs / suggestions.

[arifeld]

Hey Tommy,

I love the new update (the new UI and better logging).

I just have a few bugs (which you probably already know about) and a few suggestions. (We're on version 3.1.0)

Bugs:

1. Admin Reports - when you mark them as "finished", they still come up as "Pending" on the notification bar on the right. You probably already know this, but I thought I should just let you know in-case you didn't already.

2. The new "Add Slay" UI - when typing a custom message, the "No reason specified" is not automatically removed, instead you must select it again to delete it.

3. The "Death Scene" button in "Take Action" doesn't always find the Death Scene, I assume this is because you are checking for the death scene involving both the reported player and the victim. However, perhaps it would be better if the button just showed the victims death scene (unless of course they don't have one.)

4. When adding a slay, the entire slay reason is not put into the "Conclusion" section, only one line is ever displayed inside of it.

EDIT:

5. Innocent's killing Innocents with fall damage does not come up in red text (as compared to other team-damage.)

Suggestions:

1. The fact that admins can no longer see if a report has been kept (the "Waiting for victim" notification) is incredibly frustrating as it requires admins to be constantly looking for new notifications. Perhaps just adding a "Victim Responded" option in "Response Status" would be good. However, if this was to be added, could admins still "claim" the report even before the victim responds? That feature was quite irritating, especially when the victim left, as no status could be set to it.

2. Sort of a minor bug on admin reports, the "N/A" in the "Cancelled" section is not centered - this isn't much of a problem, just a UI issue.

3. The "User has been slain by Admin for reason" message seems to have lost the colours it once had, making the message look like a wall of text instead of a formatted message.

Thank you in advance for making such a cool update (I really love the shot logs integrated into the death scene.)

EDIT:

4. Perhaps introduce a setting that disables the "Keep/Forgive" pop-up until the player dies or the round ends - having the popup appear and lock the mouse can cause people to die in firefights / fall to their death because they can't control their mouses.

[Tommy228]

Sorry for the late answer, I don't have a lot of time recently but I'll try working a bit on the repo this weekend.

Bugs

1. Admin Reports - when you mark them as "finished", they still come up as "Pending" on the notification bar on the right. You probably already know this, but I thought I should just let you know in-case you didn't already.

This has already been reported, should be easy to fix.

2. The new "Add Slay" UI - when typing a custom message, the "No reason specified" is not automatically removed, instead you must select it again to delete it.

Already fixed if I remember, gotta try it again.

3. The "Death Scene" button in "Take Action" doesn't always find the Death Scene, I assume this is because you are checking for the death scene involving both the reported player and the victim. However, perhaps it would be better if the button just showed the victims death scene (unless of course they don't have one.)

If I remember, it was not always working correctly on 2.4. It's probably broken because the backend code had a lot of changes and the "Find Death Scene" button wasn't updated for these changes. For now, you can simply search for the kill on the damagetab to view the death scene.

4. When adding a slay, the entire slay reason is not put into the "Conclusion" section, only one line is ever displayed inside of it.

5. Innocent's killing Innocents with fall damage does not come up in red text (as compared to other team-damage.)

I think these have already been reported, I'll look into them as well.

Suggestions

1. The fact that admins can no longer see if a report has been kept (the "Waiting for victim" notification) is incredibly frustrating as it requires admins to be constantly looking for new notifications. Perhaps just adding a "Victim Responded" option in "Response Status" would be good. However, if this was to be added, could admins still "claim" the report even before the victim responds? That feature was quite irritating, especially when the victim left, as no status could be set to it.

I know not being able to set the status all the time was quite frustrating. It was a bad idea and this is why I have changed it and I'm gonna keep it that way. The best would be a "Victim Responded" status and I have already started working on this change.

I'll see what I can do for 2. and 3. later (focusing on bugs atm). Anyway, thanks for the feedback, that's really useful.

[arifeld]

Thanks for the response! I look forward to seeing the changes - unfortunately the server I admin on has reverted back to the previous version due to the issues. However, with the issues I posted above fixed, I reckon we'll be updated in no time ^-^

[arifeld]

I've added another suggestion to the original post, definitely not urgent but could be useful.

4. Perhaps introduce a setting that disables the "Keep/Forgive" pop-up until the player dies or the round ends - having the popup appear and lock the mouse can cause people to die in firefights / fall to their death because they can't control their mouses.

[Butanal]

1. Should be fixed with 4c8532852efad944618c4104e6014a610bd953ce almost 2 years later (decided to remove admin reports from the pending report count since only the admin who created it will handle it, not all admins).

Will take a look at the rest, depending on how critical these issues are.

[arifeld]

Haha, thanks @Butanal!

[SouthpawAnex]

I like these suggestions, I also have a few bugs and suggestions to list:

BUGS:

• Multiple report glitch: When you get reported more than once, you can't respond to multiple reports and have to reconnect.
• Pending report notification bug: The "Pending Reports" notification sometimes says a number, as if there are pending reports, yet there isn't any pending.
• Grammar issues: For example "You Forgave You".

SUGGESTIONS: You released a really good version a few months ago but reverted it due to major bugs, please could you bring it back out, the Discord webhook feature was also really handy, along with some of the other in-game features the addon brought.

[BadgerCode]

It seems that discord is blocking requests from Garry's Mod servers. https://web.archive.org/web/20190406220010/https://forum.facepunch.com/gmoddev/btvju/Next-Update-v9-October-2018-Update-is-live/9/#postcwrbdn

For some reason Discord, via Cloudflare is blocking the user agent string GMod uses. You can replicate it by sending any request with the header User-Agent of

Valve/Steam HTTP Client 1.0 (4000)

In order to get around this, you will need to set up an endpoint on a web server (a proxy) to forward your discord webhooks. GMod server -> Your proxy -> Discord