PdfBox-Android icon indicating copy to clipboard operation
PdfBox-Android copied to clipboard

support for PDShading waiting to merge

Open anyongjin opened this issue 3 years ago • 1 comments

I found that PDshading support has not been added to this repository, and the rendering and creation about shading will also be ignored. I added support for shading(type 1 to type 7) with the latest version of pdfbox code and the android.graphics library. Most of the code is just simple modifications of pdfbox. and unit tests for types 2,3,4 are also added.

The source code is latest two commits in here;

Here is 3 file to test shading 2,3,4: shading2.pdf shading3.pdf shading4.pdf

Please create a new branch named shading to merge and test. or can i just create a pull request to master?

waiting for you reply, thank you

Edit 03/23

I fixed an index error bug, and optimized some heavy functions. big_sm (1).pdf it would cost about 140s to render the big_sm (1).pdf to images. Now it would cost just about 33s. here is the method cost log files: after_optimize.log before_optimize.log

anyongjin avatar Mar 22 '22 04:03 anyongjin

If you move some of your commits into separate branches in your repository using rebase / cherry-pick, you can open multiple pull requests here targeting TomRoush/master with different sets of changes. For example, you could create a branch called "add-pdshading" that starts at the latest commit from TomRoush/master and then push only your PDShading changes to that branch. That way it is completely separate from any other changes you might make

TomRoush avatar Mar 27 '22 22:03 TomRoush